841027 - [Transitions. UX] Value-selector dialog should fade in instead of sliding from the bottom

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Michał Budzyński (:michalbe)]

According to http://buildingfirefoxos.com/transitions.html#prompts and https://bugzilla.mozilla.org/show_bug.cgi?id=834712#c6 the spec have been changed.

Comment 1

[Michał Budzyński (:michalbe)]

Attachment: patch

Comment 2

[Michał Budzyński (:michalbe)]

merged
https://github.com/mozilla-b2g/gaia/commit/2488b3fa3998d78628fa75e3d385b7055dc46e9d

Comment 3

[Maria Angeles Oteo (:oteo)]

Hi Michal,
could you please ask for the gaia-approval-v1 ? so we can land the patch in v1.0.1 as from UX point of view is critical for Telefonica and it seems a simple and very low risk patch.
Thanks

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Hi,
the bug title looks very misleading. Sorry I didn't notice that since the original bug..
Could you change it to match the fix? It's about value selector transition fix instead of all other  prompts in system. Thanks.

Comment 5

[Michał Budzyński (:michalbe)]

Comment on attachment 713743 [details]
patch

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 713743 [details]
patch

Really low risk. 2 lines css changes.

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

(In reply to Vivien Nicolas (:vingtetun) (:21) from comment #6)
> Comment on attachment 713743 [details]
> patch
> 
> Really low risk. 2 lines css changes.

and there was a (simple) merge conflict.

v1-train: 2242d967832e49d7a09cc3ec8742add34cf020de

Comment 8

[Maria Angeles Oteo (:oteo)]

This bug is included in the list of Telefonica UX-P1 bugs that need to be landed in v1.0.1, could you please mege it in that branch?
Thanks a lot

Comment 9

[Jason Smith [:jsmith]]

(In reply to Maria Angeles Oteo:oteo from comment #8)
> This bug is included in the list of Telefonica UX-P1 bugs that need to be
> landed in v1.0.1, could you please mege it in that branch?
> Thanks a lot

Adding needsinfo to akeybl to address comment 8.