841300 - JavaScript Error: Applications is not defined in landing page

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Cristian Rodriguez (:crdlc)]

E/GeckoConsole(  679): [JavaScript Error: "ReferenceError: Applications is not defined" {file: "app://homescreen.gaiamobile.org/js/landing.js" line: 32}]

We have a problem when users touch on landing page because there are dead code not needed

Comment 1

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

no risk

Removing dead code that causes Javascript errors and listeners not needed

Comment 2

[Cristian Rodriguez (:crdlc)]

Comment on attachment 713830 [details]
Patch v1

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 807529
User impact if declined: no but less listeners and no error on logs
Testing completed: yes
Risk to taking this patch (and alternatives if risky): no risk, null

Comment 3

[Cristian Rodriguez (:crdlc)]

https://github.com/mozilla-b2g/gaia/commit/ccc9424f194022c825128acdaf682e3cf2cb2f01

Comment 4

[Cristian Rodriguez (:crdlc)]

Comment on attachment 713830 [details]
Patch v1

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: nothing, but less listeners and no error on logs
Testing completed: yes
Risk to taking this patch (and alternatives if risky): null

Comment 5

[Alex Keybl [:akeybl]]

Comment on attachment 713830 [details]
Patch v1

Approving for v1-train (v1.1) but not v1.0.1.

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: 1d7d990a5d3340b76ec14470b23d703bacb62382