841381 - error: 'class nsTArray<unsigned int>' has no member named 'GreatestIndexLtEq' after bug 618479 landing

Status: RESOLVED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[Mark Banner (:standard8)]

Attachment: Paritial fix

Since bug 618479 landed, we're getting the following error on comm-central builds:

../../../../mailnews/imap/src/nsImapFlagAndUidState.cpp: In member function 'imapMessageFlagsType nsImapFlagAndUidState::GetMessageFlagsFromUID(uint32_t, bool*, int32_t*)':
../../../../mailnews/imap/src/nsImapFlagAndUidState.cpp:238:20: error: 'class nsTArray<unsigned int>' has no member named 'GreatestIndexLtEq'

I'm attaching a partial patch, however one of the imap xpcshell tests is still failing:

TEST-UNEXPECTED-FAIL | /Users/moztest/comm/main/tb/mozilla/_tests/xpcshell/mailnews/imap/test/unit/test_imapFilterActions.js | true == false - See following stack:
JS frame :: /Users/moztest/comm/main/src/mozilla/testing/xpcshell/head.js :: do_throw :: line 461
JS frame :: /Users/moztest/comm/main/src/mozilla/testing/xpcshell/head.js :: do_report_result :: line 563
JS frame :: /Users/moztest/comm/main/src/mozilla/testing/xpcshell/head.js :: _do_check_eq :: line 573
JS frame :: /Users/moztest/comm/main/src/mozilla/testing/xpcshell/head.js :: do_check_eq :: line 580
JS frame :: /Users/moztest/comm/main/tb/mozilla/_tests/xpcshell/mailnews/imap/test/unit/test_imapFilterActions.js :: testCounts :: line 753
JS frame :: /Users/moztest/comm/main/tb/mozilla/_tests/xpcshell/mailnews/imap/test/unit/test_imapFilterActions.js :: checkMarkUnread :: line 176
JS frame :: /Users/moztest/comm/main/tb/mozilla/_tests/xpcshell/mailnews/imap/test/unit/test_imapFilterActions.js :: doTest :: line 480
JS frame :: /Users/moztest/comm/main/src/mozilla/testing/xpcshell/head.js :: _Timer.prototype.notify :: line 131
native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0

Comment 1

[Boris Zbarsky [:bzbarsky]]

Sorry I didn't check comm-central.  :(

The partial patch is returning a value for *ndx that doesn't point to the found thing.  It needs to decrement *ndx by 1 when found, no? Could that be causing the remaining failure?

Comment 2

[Mark Banner (:standard8)]

Attachment: The fix

I know Neil suggested it on irc, but it works, and we now pass all xpcshell tests.

Comment 3

[Mark Banner (:standard8)]

https://hg.mozilla.org/comm-central/rev/daea5c34853a

(In reply to Boris Zbarsky (:bz) from comment #1)
> Sorry I didn't check comm-central.  :(

No problem. Thanks for the hint, it was already sitting on my hard drive unfortunately.

Comment 4

[Liam Zebedee Edwards-Playne]

Trying to build here, getting an error related to this bug's revision:

nsImapFlagAndUidState.cpp:238:26: error: ‘class nsTArray<unsigned int>’ has no member named ‘IndexOfFirstElementGt’

Comment 5

[Mark Banner (:standard8)]

(In reply to Liam Zebedee Edwards-Playne from comment #4)
> Trying to build here, getting an error related to this bug's revision:
> 
> nsImapFlagAndUidState.cpp:238:26: error: ‘class nsTArray<unsigned int>’ has
> no member named ‘IndexOfFirstElementGt’

That sounds like you haven't updated mozilla-central in sync with comm-central. You generally need to keep both up to date at the same time with "./client.py checkout".