841616 - Open Location dialog should be able to open a private window

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[[e-mail]]

Without setting any preferences in that case of course.

Comment 1

[[e-mail]]

Attachment: Possible patch

Comment 2

[Ian Neal]

Comment on attachment 714186 [details] [diff] [review]
Possible patch

>+++ b/editor/ui/composer/content/ComposerCommands.js
>@@ -2091,16 +2091,19 @@ var nsOpenRemoteCommand =
>       case "2": // edit
>         editPage(params.url);
>         break;
>       case "3": // new tab
>         win.focus();
>         var browser = win.getBrowser();
>         browser.selectedTab = browser.addTab(params.url, {allowThirdPartyFixup: true});
>         break;
>+      case "4": // private
>+        openNewPrivateWith(params.url):
Oops, ";" not ":"

r=me with that fixed

Comment 3

[[e-mail]]

(In reply to Ian Neal from comment #2)
> Oops, ";" not ":"
Bah, I'd mistyped it in navigator.js, copied and pasted it into ComposerCommands.js, then noticed and fixed it in navigator.js but promptly forgotten to check editor :-(

Comment 4

[Philip Chee]

Comment on attachment 714186 [details] [diff] [review]
Possible patch

r=me with the ":" vs ";" fixed.

Comment 5

[[e-mail]]

Pushed comm-central changeset 94c2be83ba41.