84163 - javascript strict warnings in PageInfoOverlay.xul

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect, P2)

Description

[Henrik Gemal]

Warning: trailing comma is not legal in ECMA-262 object initializers
Source File: chrome://pippki/content/PageInfoOverlay.xul
Line: 69, Column: 10
Source Code:
          };

Warning: trailing comma is not legal in ECMA-262 object initializers
Source File: chrome://pippki/content/PageInfoOverlay.xul
Line: 99, Column: 4
Source Code:
    };

Warning: redeclaration of var hdr
Source File: chrome://pippki/content/PageInfoOverlay.xul
Line: 145, Column: 12
Source Code:
        var hdr = bundle.formatStringFromName("pageInfo_WeakEncryption",

Warning: redeclaration of var msg1
Source File: chrome://pippki/content/PageInfoOverlay.xul
Line: 149, Column: 12
Source Code:
        var msg1 = bundle.formatStringFromName("pageInfo_Privacy_Weak1",

Warning: redeclaration of var msg2
Source File: chrome://pippki/content/PageInfoOverlay.xul
Line: 153, Column: 12
Source Code:
        var msg2 = bundle.GetStringFromName("pageInfo_Privacy_Weak2");

Warning: redeclaration of var hdr
Source File: chrome://pippki/content/PageInfoOverlay.xul
Line: 156, Column: 12
Source Code:
        var hdr = bundle.GetStringFromName("pageInfo_NoEncryption");

Warning: redeclaration of var msg1
Source File: chrome://pippki/content/PageInfoOverlay.xul
Line: 159, Column: 12
Source Code:
        var msg1 = bundle.formatStringFromName("pageInfo_Privacy_None1",

Warning: redeclaration of var msg2
Source File: chrome://pippki/content/PageInfoOverlay.xul
Line: 163, Column: 12
Source Code:
        var msg2 = bundle.GetStringFromName("pageInfo_Privacy_None2");

Comment 1

[Mitchell Stoltz (not reading bugmail)]

->Crypto

Comment 2

[Mitchell Stoltz (not reading bugmail)]

really this time.

Comment 3

[Bob Lord]

Moving to Product: PSM for triage

Comment 4

[Stephane Saux]

-> p2
target -> 2.1

Comment 5

[(Don't use, old account) - Kai Engert]

Attachment: Patch to fix the reported syntax errors

Comment 6

[(Don't use, old account) - Kai Engert]

->kai

I was unable to test it, as I don't know the testcase for the messages. However,
there were simple syntax errors and I believe I fixed them.

Comment 7

[(Don't use, old account) - Kai Engert]

David, please review.

Comment 8

[David P. Drinan]

r=ddrinan.

Comment 9

[Christopher Blizzard (:blizzard)]

sr=blizzard

Comment 10

[Henrik Gemal]

who's up for a checkin?

Comment 11

[John Unruh]

Mass assigning QA to ckritzer.

Comment 12

[Javier Delgadillo]

Checked in patch for Kai

Comment 13

[Stephane Saux]

keywords->verifyme

Comment 14

[John Unruh]

Verified.