Closed
Bug 841669
Opened 11 years ago
Closed 11 years ago
Contact list stops loading at certain contact: "TypeError: extraFbItems is undefined"
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(blocking-b2g:tef+, b2g18+ fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 fixed)
VERIFIED
FIXED
blocking-b2g | tef+ |
People
(Reporter: MattN, Assigned: jmcf)
References
Details
(Keywords: b2g-testdriver, unagi)
Attachments
(1 file)
189 bytes,
text/html
|
crdlc
:
review+
akeybl
:
approval-gaia-v1+
|
Details |
02-14 21:43:01.206 E/GeckoConsole( 489): [JavaScript Error: "TypeError: extraFbItems is undefined" {file: "app://communications.gaiamobile.org/contacts/js/fb/fb_contact.js" line: 327}] The contact list fails to completely load in the Contacts app because of the JavaScript error above. Build ID: 20130212070205
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → jmcf
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•11 years ago
|
||
I cannot reproduce in master but providing a patch to guarantee there is no runtime error if extraFbItems is not defined
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #714286 -
Flags: review?(crdlc)
Comment 3•11 years ago
|
||
ok, reviewing
Comment 4•11 years ago
|
||
Comment on attachment 714286 [details]
Pointer to GH PR #8122
minor change without risk
Attachment #714286 -
Flags: review?(crdlc) → review+
Comment 5•11 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/c64ee7587c9682856ae653bce95c56aea2daa979
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 6•11 years ago
|
||
Comment on attachment 714286 [details]
Pointer to GH PR #8122
NOTE: If blocking-basecamp+ is set, just land it for now.
[Approval Request Comment]
Bug caused by (feature/regressing bug #):
User impact if declined: high, Contact list stops loading at certain contact sometimes
Testing completed: yes
Risk to taking this patch (and alternatives if risky): null
Attachment #714286 -
Flags: approval-gaia-v1?
Updated•11 years ago
|
status-b2g18:
--- → affected
status-b2g18-v1.0.0:
--- → wontfix
Comment 7•11 years ago
|
||
Comment on attachment 714286 [details]
Pointer to GH PR #8122
Approving for v1-train (v1.1), but wontfixing for v1.0.1 since we've only had one report of this bug.
Attachment #714286 -
Flags: approval-gaia-v1? → approval-gaia-v1+
Comment 8•11 years ago
|
||
v1-train: ef46c141213ad80f2629a268e3a285c2b54fba7e
Reporter | ||
Comment 9•11 years ago
|
||
Thanks. The entire contact list loads again after updating to 20130219070200 (beta channel).
Status: RESOLVED → VERIFIED
Comment 10•11 years ago
|
||
(we'd like this on v1.0.1 after all, to fix bug 841669)
Updated•11 years ago
|
blocking-b2g: --- → tef+
Comment 11•11 years ago
|
||
v1.0.1: 9d2c03f34d9f08b3ebc30ac06868de0bdc678f9a
You need to log in
before you can comment on or make changes to this bug.
Description
•