842220 - B2G CDMA: [Gaia] Add signal notification function for CDMA/EVDO network

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Ken Chang[:kenkai]]

For supporting the signal notification function of CDMA/Evdo, Gaia has to read the new signal information from RIL for CDMA/EVDO network.

Comment 1

[Ken Chang[:kenkai]]

For GSM network, we should modify following code

icon.dataset.level = Math.ceil(voice.relSignalStrength / 20); // 0-5

to be
        if (voice.signal.gsmSignal >= -86) {
          icon.dataset.level = 5;
        } else if (voice.signal.gsmSignal >= -88) {
          icon.dataset.level = 4;
        } else if (voice.signal.gsmSignal >= -97) {
          icon.dataset.level = 3;
        } else if (voice.signal.gsmSignal >= -102) {
          icon.dataset.level = 2;
        } else if (voice.signal.gsmSignal >= -108) {
          icon.dataset.level = 1;
        } else {
          icon.dataset.level = 0;
        }

Comment 2

[Ken Chang[:kenkai]]

And the |relSignalStrength| have been removed from DOM API.
the |signalStrength| have been moved to |signal.gsmSignal|

Comment 3

[Kai-Chih Hu [:khu]]

Neo, we need the UX design for this item. Thanks!

Comment 4

[Anshul]

(In reply to Ken Chang from comment #1)
> For GSM network, we should modify following code
> 
> icon.dataset.level = Math.ceil(voice.relSignalStrength / 20); // 0-5
> 
> to be
>         if (voice.signal.gsmSignal >= -86) {
>           icon.dataset.level = 5;
>         } else if (voice.signal.gsmSignal >= -88) {
>           icon.dataset.level = 4;
>         } else if (voice.signal.gsmSignal >= -97) {
>           icon.dataset.level = 3;
>         } else if (voice.signal.gsmSignal >= -102) {
>           icon.dataset.level = 2;
>         } else if (voice.signal.gsmSignal >= -108) {
>           icon.dataset.level = 1;
>         } else {
>           icon.dataset.level = 0;
>         }
Ken, can we not keep this logic in RIL as it is now and just use the relSignalStrength? All gaia needs to know is how many signal strength bars to display and that it already does based on relSignalStrenth. RIL can figure out for each network GSM/CDMA/Evdo and then calculate the rilSignalStrength and send it to Gaia.

Comment 5

[Ken Chang[:kenkai]]

(In reply to Anshul from comment #4)
> Ken, can we not keep this logic in RIL as it is now and just use the
> relSignalStrength? All gaia needs to know is how many signal strength bars
> to display and that it already does based on relSignalStrenth. RIL can
> figure out for each network GSM/CDMA/Evdo and then calculate the
> rilSignalStrength and send it to Gaia.
Hi Anshul, sure. And Edgar have done what your said.

Comment 6

[Neo Hsieh [:neo]]

Attachment: CDMA_Signal_icon.zip

Please check attached file.

Comment 7

[Ken Chang[:kenkai]]

Arthur, can you please help?

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

In bug 878851 we changed the technology icon from png to characters.

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: link to https://github.com/mozilla-b2g/gaia/pull/11855

Alive, could you help review this change? Thanks!

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks alive!

master: https://github.com/mozilla-b2g/gaia/commit/ce41a1f6680eaf4395a8bfcb7457f1d9bbfd6267