842254 - Thunderbird/SeaMonkey comm-central builds fail with "KeyError: 'MOZ_APP_VENDOR'"

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Comment 1

[Frank Wein [:mcsmurf]]

Whoops, hit enter too soon.

Currently Thunderbird/SeaMonkey builds fail with this error:

/builds/slave/tb-c-cen-l64-d-000000000000000/build/objdir-tb/mozilla/config/nsinstall -D ../../mozilla/dist/
/builds/slave/tb-c-cen-l64-d-000000000000000/build/objdir-tb/_virtualenv/bin/python /builds/slave/tb-c-cen-l64-d-000000000000000/build/mozilla/toolkit/mozapps/installer/informulate.py \
		../../mozilla/dist//thunderbird-21.0a1.en-US.linux-x86_64.json \
		BUILDID=20130217235329 \
		MOZ_SOURCE_REPO=http://hg.mozilla.org/mozilla-central \
		MOZ_SOURCE_STAMP=de56ae61946d \
		MOZ_PKG_PLATFORM=linux-x86_64
Traceback (most recent call last):
  File "/builds/slave/tb-c-cen-l64-d-000000000000000/build/mozilla/toolkit/mozapps/installer/informulate.py", line 46, in <module>
    main()
  File "/builds/slave/tb-c-cen-l64-d-000000000000000/build/mozilla/toolkit/mozapps/installer/informulate.py", line 37, in main
    all_key_value_pairs = dict([(x.lower(), buildconfig.substs[x]) for x in important_substitutions])
KeyError: 'MOZ_APP_VENDOR'
make[3]: Leaving directory `/builds/slave/tb-c-cen-l64-d-000000000000000/build/objdir-tb/mail/installer'

Possible solution can be found in Bug 839298 Comment 17. But I think the
real/correct(?) solution would be to make sure all the vars listed in
http://hg.mozilla.org/mozilla-central/file/524e7bc67431/toolkit/mozapps/installer/informulate.py are included (probably not the right term) in the buildconfig python module. Not sure how exactly this works though...

Comment 2

[Mark Banner (:standard8)]

Attachment: The fix

Ok, this fixes it enough to get us running again

Comment 3

[Mark Banner (:standard8)]

I've a feeling the information may still be wrong for us in the json file, but at least this will get us green again.

Comment 4

[Philip Chee]

Pushed to comm-central
comm-central changeset e4a72afda8ab

http://hg.mozilla.org/comm-central/rev/e4a72afda8ab