Closed Bug 842692 Opened 11 years ago Closed 11 years ago

plugin click-to-play play button has default cursor

Categories

(Core Graveyard :: Plug-ins, defect, P2)

Product:
Core Graveyard
Component:
Plug-ins
Version:
21 Branch
Type:
defect

Tracking

(firefox21 verified, firefox22 verified)

Status:
VERIFIED FIXED
Milestone:
mozilla22
Tracking Flags:
Tracking Status
firefox21 --- verified
firefox22 --- verified

People

(Reporter: c.ascheberg, Assigned: c.ascheberg)

References

Details

(Whiteboard: [CtpDefault:P2])

Attachments

(1 file)

possible patch
1.26 KB, patch
jaws
: review+
bajaj
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
The play icon of the plugin click-to-play UI |:-moz-handler-clicktoplay .icon| on hover shows the default cursor. It should show the pointer cursor.
Dammit. Apparently <html:button> has a default style rule of cursor: default so we need to override that with everything else.
Assignee: nobody → benjamin
Priority: -- → P2
Whiteboard: [CtpDefault:P2]
Attached patch possible patch — — Splinter Review 
This seems to work
Attachment #716213 - Flags: review?(jAwS)
Attachment #716213 - Flags: review?(jAwS) → review+
Thanks for taking this.
Assignee: benjamin → c.ascheberg
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/31daf94fb0a4
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Version: Trunk → 21 Branch
Comment on attachment 716213 [details] [diff] [review]
possible patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 831921
User impact if declined: mouse cursor will not be a hand (pointer) on the play button, fx21 is first release for new CTP ui.
Testing completed (on m-c, etc.): locally and landed on m-c
Risk to taking this patch (and alternatives if risky): none expected
String or UUID changes made by this patch: none
Attachment #716213 - Flags: approval-mozilla-aurora?
Attachment #716213 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Flagging for verification against Firefox 21 and 22.
Keywords: verifyme
This is still happening for the X button. Any thoughts?
(In reply to Paul Silaghi [QA] from comment #9)
> This is still happening for the X button. Any thoughts?

According to bug 831921 comment 20 this is intended. I'd say it does make sense as the performed action is different from the rest of the UI.
Based on comment 10 verified fixed on FF 21.0a2 (2013-03-17), 22.0a1 (2013-03-17) Win 7, Ubuntu 12.04 and Mac OS X 10.7.5
Status: RESOLVED → VERIFIED
status-firefox21: fixed → verified
status-firefox22: fixed → verified
Keywords: verifyme
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: