844351 - remove nsISSLErrorListener

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

nsIWebProgressListener should be used instead, or not at all.

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

16:35         bsmith | keeler: using nsIWebProgressListener works for people
                     | that are listening for web content loads (loads that
                     | occur in docshells)
16:37         bsmith | keeler: But, there are also loads that don't occur in
                     | docshells, like what thunderbird does.
16:37         bsmith | So, you might get some people asking you to explain how
                     | thunderbird should replace its nsISSLErrorListener
                     | implementation
16:38         bsmith | When you create a channel, you pass in some callbacks
16:38         bsmith | and one of the callbacks is a callback that gets called
                     | when the channel is closed
16:38         bsmith | and that callback gets the nsresult for the channel
16:38         bsmith | which you can convert into an NSS error code using the
                     | various PSM functions for doing so
16:39         bsmith | I think nsIDocShell deals with errors that way.
16:39         bsmith | I remember that if you look in Thunderbird's IMAP
                     | implementation, they already handle errors that way
16:39         bsmith | for non-SSL stuff.
16:40         bsmith | So, they basically just need to add more cases to their
                     | switch statement to handle the SSL- and Cert- related
                     | errors

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Doesn't look like this depends on bug 846581 anymore. As far as I can tell, there's nothing still using this interface for anything meaningful. (There are some uses in comm-central, but the implementations don't actually do anything.)

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Posted a notification that this is going away: https://groups.google.com/forum/#!topic/mozilla.dev.platform/AnRVB_DEcyA

Comment 4

[Lawrence Mandel [:lmandel] (use needinfo)]

ni Jorge in case this needs to be documented for add-on compat. I don't know the timeline for this change but it was announced on dev-platform this week.

Comment 5

[Jorge Villalobos [:jorgev] (he/him)]

A few add-ons seem to use it, but it doesn't look like a big concern. Flagging for future documentation.

Comment 6

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Attachment: patch

Cykesiopka - would you mind reviewing this? Thanks.

Comment 7

[:Cykesiopka]

Comment on attachment 8584813 [details] [diff] [review]
patch

Review of attachment 8584813 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 8

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Thanks!
https://hg.mozilla.org/integration/mozilla-inbound/rev/83af1139a6d3

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/83af1139a6d3