Closed Bug 844516 Opened 11 years ago Closed 11 years ago

Improve wait for Preferences:Data in robocop tests

Categories

(Firefox for Android Graveyard :: General, defect)

x86
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 22

People

(Reporter: gbrown, Assigned: gbrown)

Details

Attachments

(1 file)

In testAddonManager and testPasswordEncrypt, there are hacks for verifying that preferences have been set. The hacks can be removed now.
Code stolen from testDistribution.
Attachment #717555 - Flags: review?(jmaher)
Summary: Improve wait for Preferences:Data in robocop tests; r=jmaher → Improve wait for Preferences:Data in robocop tests
Comment on attachment 717555 [details] [diff] [review]
remove pref hacks

Review of attachment 717555 [details] [diff] [review]:
-----------------------------------------------------------------

I really don't understand this patch, but if it passes reliably on try server I don't have any objections.
Attachment #717555 - Flags: review?(jmaher) → review+
https://hg.mozilla.org/mozilla-central/rev/eea13ee399c5
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: