844787 - Update TabView - close() function to not use toLocaleUpperCase()

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Daniela Petrovici]

We need to update /lib/tabview.js library - close() function to not use toLocaleUpperCase() since bug 648294 was fixed.

Comment 1

[Kyle Colle-Tripp]

Hey Andreea, been taking a look through tabview.js, but I don't see toLocaleUpperCase(). Any starting points you could give me?

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Looks like this was fixed up to beta by the landing of the patch on bug 873473. So what we need here is a patch for the release and esr17 branch.

Comment 3

[Jonathan French (:jfrench)]

Also Kyle for reference feel free to click on the 'Diff' link in the rev1.2 patch for that bug and you will see the removal, buried in among many other changes.

Comment 4

[Balazs Juhasz (:balazs)]

Attachment: remove bug workarounds (mozilla-esr17) rev1.0

Removed workarounds (mozilla-esr17) for bug 648294 and bug 596504

Functional:
http://mozmill-crowd.blargon7.com/#/functional/report/fb97b6210ae70da1b9ace674459e1116
http://mozmill-crowd.blargon7.com/#/functional/report/fb97b6210ae70da1b9ace674459dd65e

Endurance:
http://mozmill-crowd.blargon7.com/#/endurance/report/fb97b6210ae70da1b9ace674459e4dff

Comment 5

[Andrei Eftimie]

Comment on attachment 801018 [details] [diff] [review]
remove bug workarounds (mozilla-esr17) rev1.0

I wouldn't mind taking this, but as Andreea is the mentor and she's mentioned in the commit message, she was probably intended as reviewer here.

Comment 6

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 801018 [details] [diff] [review]
remove bug workarounds (mozilla-esr17) rev1.0

Review of attachment 801018 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Juhasz,
Added it on esr17, on release it will be a merge today from beta so it's not needed anymore. 
I'll close the bug once that is done too.

Thanks!
http://hg.mozilla.org/qa/mozmill-tests/rev/109c4e3c622c (esr17)

Comment 7

[Andreea Matei [:AndreeaMatei]]

Merge is up, we have the changes in release too:
http://hg.mozilla.org/qa/mozmill-tests/file/mozilla-release/lib/tabview.js#l525

We're done here, Juhasz, thanks and you're welcome to help in other bugs if you want.