844792 - Warn about the upcoming removal of multipart support in XHR

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Henri Sivonen (:hsivonen)]

Warn ahead of bug 843508.

Comment 1

[Henri Sivonen (:hsivonen)]

Attachment: Add a warning

Comment 2

[Henri Sivonen (:hsivonen)]

Thanks.

https://hg.mozilla.org/integration/mozilla-inbound/rev/e9e4dab21e79

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e9e4dab21e79

Comment 4

[Henri Sivonen (:hsivonen)]

Comment on attachment 717835 [details] [diff] [review]
Add a warning

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 237319
User impact if declined: The removal of mostly unnecessary code is delayed. This patch adds an error console warning to give the one or two Web authors who use the feature an advance notice about the feature going away.
Testing completed (on m-c, etc.): Landed on m-c without problems.
Risk to taking this patch (and alternatives if risky): Extremely low risk (just logs a message).
String or UUID changes made by this patch: Adds one string. However, the string is an error console warning, so failure to translate is tolerable.

Comment 5

[Masatoshi Kimura [:emk]]

Are chunked response type going to be spec'ed and implemented by other browsers? It looks like it does not.
http://xhr.spec.whatwg.org/#interface-xmlhttprequest
I don't think it's a good idea to force Web developers to migrate once again.

Comment 6

[Henri Sivonen (:hsivonen)]

Good point. I'll follow up with a patch that recommends Web Sockets and Server-Sent Events but doesn't recommend chunked response.

Comment 7

[bhavana bajaj [:bajaj]]

CCing Axel here to weigh on the l10n impact . We think we should move fwd with the warning here .Pike what are the best options to deal with l10n here ?

Comment 8

[Axel Hecht [:Pike]]

My suggestion is to hard-code the string for aurora, and not expose it to l10n at all.

Comment 9

[Henri Sivonen (:hsivonen)]

Attachment: Adjust warning text, make non-localizable

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 719865 [details] [diff] [review]
Adjust warning text, make non-localizable

(though, I hope chunked data will be added to XHR spec)

Comment 11

[Henri Sivonen (:hsivonen)]

Thanks.
https://hg.mozilla.org/integration/mozilla-inbound/rev/90c0a4c5a4b6

Comment 12

[Henri Sivonen (:hsivonen)]

Attachment: Merged patch for aurora

This patch combines the two patches landed on inbound, hence, carrying forward r+.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 237319
User impact if declined: The removal of mostly unnecessary code is delayed. This patch adds an error console warning to give the one or two Web authors who use the feature an advance notice about the feature going away.
Testing completed (on m-c, etc.): Trivial patch. Has landed.
Risk to taking this patch (and alternatives if risky): Extremely low risk (just logs a message).
String or UUID changes made by this patch: None. The log message is non-localizable.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/90c0a4c5a4b6

Comment 14

[bhavana bajaj [:bajaj]]

Comment on attachment 719957 [details] [diff] [review]
Merged patch for aurora

Thanks for work around done for the l10n here :) Low risk patch, approving on aurora

Comment 15

[Henri Sivonen (:hsivonen)]

Thanks. Landed on Aurora:
https://hg.mozilla.org/releases/mozilla-aurora/rev/feb9b4bac9ac

Comment 16

[Henri Sivonen (:hsivonen)]

Comment on attachment 719957 [details] [diff] [review]
Merged patch for aurora

[Approval Request Comment]
See comment 12.

Can we uplift all the way to beta considering that this is extremely low risk and has no l10n impact?

Comment 17

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 719957 [details] [diff] [review]
Merged patch for aurora

Approving since it's great to give 2 release warning (or close to it anyway) so let's get this into Beta 3 (ie: land to beta before tomorrow).

Comment 18

[Henri Sivonen (:hsivonen)]

Thanks. Landed on beta:
https://hg.mozilla.org/releases/mozilla-beta/rev/ede329b80bc5

Comment 19

[Kohei Yoshino [:kohei]]

I've added this bug to the compatibility doc. Please correct the info if wrong.
https://developer.mozilla.org/en-US/docs/Site_Compatibility_for_Firefox_20