Closed Bug 844834 Opened 11 years ago Closed 11 years ago

Text color is white instead of black on Context Menu -> Site Settings

Categories

(Firefox for Android Graveyard :: Awesomescreen, defect)

21 Branch
ARM
Android
defect
Not set
normal

Tracking

(firefox21 verified, firefox22 verified, fennec21+)

VERIFIED FIXED
Firefox 22
Tracking Status
firefox21 --- verified
firefox22 --- verified
fennec 21+ ---

People

(Reporter: andreea.pod, Assigned: wesj)

References

Details

(Keywords: regression)

Attachments

(4 files, 1 obsolete file)

Attached image clear_site.settings
Firefox for Android
Version: 21.0a2 (2013-02-24)
Device: Acer Iconia A500
OS: Android 3.2.1

Steps to reproduce:
1. Open Fennec
2. Go to a website
3. Long tap on the URL bar 
4. Choose "Site Settings" from the Context Menu

Actual results:
- The text color is the same as its background: white (see attached screenshot)

Expected results:
- The text color should be visible.
Looks fine on Jellybean. Honeycomb issue?
WesJ fallout from the holo theming?
tracking-fennec: --- → ?
Flags: needinfo?(wjohnston)
Blocks: 832321
tracking-fennec: ? → 21+
Flags: needinfo?(wjohnston)
Keywords: regression
Assignee: nobody → wjohnston
Attached patch Patch v1 (obsolete) — Splinter Review
Patch. Build with this at:

http://people.mozilla.com/~wjohnston/sitePrefs.apk

Can you test it on a Honeycomb device kbrosnan?
Looks great!
Attachment #719727 - Flags: review?(sriram)
(In reply to Wesley Johnston (:wesj) from comment #4)
> Created attachment 719727 [details] [diff] [review]
> Patch v1
> 
> Patch. Build with this at:
> 
> http://people.mozilla.com/~wjohnston/sitePrefs.apk
> 
> Can you test it on a Honeycomb device kbrosnan?

I somehow don't like moving padding to the styles. It breaks the layout file. Could you please move only the "textAppearance" to the styles file? Also, you might want to add "res/values-v14" to RES_DIRS in the Makefile.
Attached patch Patch v2Splinter Review
Removed the padding stuff. I think this should be in the style files (hence why I moved it, but we can figure that out some other time/place).
Attachment #719727 - Attachment is obsolete: true
Attachment #719727 - Flags: review?(sriram)
Attachment #720161 - Flags: review?(sriram)
Comment on attachment 720161 [details] [diff] [review]
Patch v2

This looks good to me.
Attachment #720161 - Flags: review?(sriram) → review+
https://hg.mozilla.org/mozilla-central/rev/5668dcdcdbdd
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
Depends on: 847849
Comment on attachment 720161 [details] [diff] [review]
Patch v2

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 832321
User impact if declined: Site settings dialog looks bad
Testing completed (on m-c, etc.): Has been on mc for a few weeks. No regressions
Risk to taking this patch (and alternatives if risky): Low risk. Mostly themeing
String or UUID changes made by this patch: None.
Attachment #720161 - Flags: approval-mozilla-aurora?
Attachment #720161 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified fixed on:
-build: Firefox for Android 22.0a1 (2013-03-12)
-device: Acer Iconia A500
-OS: Android 3.2.1
Verified fixed on:
-build: Firefox for Android 21.0a2 (2013-03-14)
-device: Acer Iconia A500
-OS: Android 3.2.1
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: