Closed
Bug 844834
Opened 11 years ago
Closed 11 years ago
Text color is white instead of black on Context Menu -> Site Settings
Categories
(Firefox for Android Graveyard :: Awesomescreen, defect)
Tracking
(firefox21 verified, firefox22 verified, fennec21+)
VERIFIED
FIXED
Firefox 22
People
(Reporter: andreea.pod, Assigned: wesj)
References
Details
(Keywords: regression)
Attachments
(4 files, 1 obsolete file)
265.66 KB,
image/png
|
Details | |
105.56 KB,
image/png
|
Details | |
34.92 KB,
image/png
|
Details | |
6.49 KB,
patch
|
sriram
:
review+
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Firefox for Android Version: 21.0a2 (2013-02-24) Device: Acer Iconia A500 OS: Android 3.2.1 Steps to reproduce: 1. Open Fennec 2. Go to a website 3. Long tap on the URL bar 4. Choose "Site Settings" from the Context Menu Actual results: - The text color is the same as its background: white (see attached screenshot) Expected results: - The text color should be visible.
Comment 1•11 years ago
|
||
Looks fine on Jellybean. Honeycomb issue?
Reporter | ||
Comment 2•11 years ago
|
||
Updated•11 years ago
|
Flags: needinfo?(wjohnston)
Updated•11 years ago
|
Updated•11 years ago
|
Assignee: nobody → wjohnston
Assignee | ||
Comment 4•11 years ago
|
||
Patch. Build with this at: http://people.mozilla.com/~wjohnston/sitePrefs.apk Can you test it on a Honeycomb device kbrosnan?
Comment 5•11 years ago
|
||
Looks great!
Assignee | ||
Updated•11 years ago
|
Attachment #719727 -
Flags: review?(sriram)
Comment 6•11 years ago
|
||
(In reply to Wesley Johnston (:wesj) from comment #4) > Created attachment 719727 [details] [diff] [review] > Patch v1 > > Patch. Build with this at: > > http://people.mozilla.com/~wjohnston/sitePrefs.apk > > Can you test it on a Honeycomb device kbrosnan? I somehow don't like moving padding to the styles. It breaks the layout file. Could you please move only the "textAppearance" to the styles file? Also, you might want to add "res/values-v14" to RES_DIRS in the Makefile.
Assignee | ||
Comment 7•11 years ago
|
||
Removed the padding stuff. I think this should be in the style files (hence why I moved it, but we can figure that out some other time/place).
Attachment #719727 -
Attachment is obsolete: true
Attachment #719727 -
Flags: review?(sriram)
Attachment #720161 -
Flags: review?(sriram)
Comment 8•11 years ago
|
||
Comment on attachment 720161 [details] [diff] [review] Patch v2 This looks good to me.
Attachment #720161 -
Flags: review?(sriram) → review+
Assignee | ||
Comment 9•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5668dcdcdbdd
Comment 10•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5668dcdcdbdd
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
Assignee | ||
Comment 11•11 years ago
|
||
Comment on attachment 720161 [details] [diff] [review] Patch v2 [Approval Request Comment] Bug caused by (feature/regressing bug #): 832321 User impact if declined: Site settings dialog looks bad Testing completed (on m-c, etc.): Has been on mc for a few weeks. No regressions Risk to taking this patch (and alternatives if risky): Low risk. Mostly themeing String or UUID changes made by this patch: None.
Attachment #720161 -
Flags: approval-mozilla-aurora?
Updated•11 years ago
|
Attachment #720161 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Reporter | ||
Comment 12•11 years ago
|
||
Verified fixed on: -build: Firefox for Android 22.0a1 (2013-03-12) -device: Acer Iconia A500 -OS: Android 3.2.1
Assignee | ||
Comment 13•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/7327827c9c84
Updated•11 years ago
|
status-firefox21:
--- → fixed
status-firefox22:
--- → fixed
Reporter | ||
Updated•11 years ago
|
Reporter | ||
Comment 14•11 years ago
|
||
Verified fixed on: -build: Firefox for Android 21.0a2 (2013-03-14) -device: Acer Iconia A500 -OS: Android 3.2.1
Status: RESOLVED → VERIFIED
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•