845080 - Extract BackgroundService superclass

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Android Sync, defect, P2)

Description

[Chris Peterson [:cpeterson]]

This change extracts some utility code from AnnouncementsService.java and AnnouncementsBroadcastService.java into a BackgroundService superclass. The idea is that other Android services will extend BackgroundService.

Comment 1

[Richard Newman [:rnewman]]

https://github.com/mozilla-services/android-sync/pull/297

Comment 2

[Chris Peterson [:cpeterson]]

https://github.com/mozilla-services/android-sync/commit/c44feb5507587ce53cf2b9b847269a460f6b771a

https://hg.mozilla.org/integration/mozilla-inbound/rev/6562cc879c53

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Backed out for build failures.
https://hg.mozilla.org/integration/mozilla-inbound/rev/80942ec06b47

https://tbpl.mozilla.org/php/getParsedLog.php?id=20126974&tree=Mozilla-Inbound

Comment 4

[Richard Newman [:rnewman]]

Change wasn't landed with fennec-copy-code.sh, so it's missing makefile entries.

Comment 5

[Richard Newman [:rnewman]]

I will reland when tree reopens.

Chris: in future, you need to run something like:

  cd ~/moz/hg/mozilla-inbound
  hg qnew -m "..."
  cd ~/moz/git/android-sync
  ./fennec-copy-code.sh ~/moz/hg/mozilla-inbound
  cd -
  hg add ...
  hg qref

Comment 6

[Richard Newman [:rnewman]]

Relanded with manifest changes:

https://hg.mozilla.org/integration/mozilla-inbound/rev/74d4c4a7e5c0

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/74d4c4a7e5c0