845573 - GC: allocate singleton frontend objects from tenured

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

Attachment: v0

In particular this immediately tenures the self-hosting global, with its hundreds of slots.

Comment 1

[Brian Hackett [Laid off!]]

Comment on attachment 718710 [details] [diff] [review]
v0

Review of attachment 718710 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/frontend/BytecodeEmitter.cpp
@@ +3483,5 @@
>  static bool
>  EmitSingletonInitialiser(JSContext *cx, BytecodeEmitter *bce, ParseNode *pn)
>  {
>      RootedValue value(cx);
> +    if (!pn->getConstantValue(cx, bce->sc->needStrictChecks(), &value, MaybeSingletonObject))

This is the only use of getConstantValue, so you can lose the newKind argument and just always allocate initializer objects from the tenured heap.

Comment 2

[Terrence Cole [:terrence]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5a0004e62900

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5a0004e62900