845631 - Remove nsXMLHttpProgressEvent

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

We should just use plain normal progress events.
Patch coming tomorrow (UOT).

Comment 1

[Masatoshi Kimura [:emk]]

Will LSProgressEvent be gone?

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Yes.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

https://tbpl.mozilla.org/?tree=Try&rev=580c551a2b87

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 718963 [details] [diff] [review]
patch

Review of attachment 718963 [details] [diff] [review]:
-----------------------------------------------------------------

You need to remove the strings from dom/locales/en-US/chrome/dom/dom.properties too.

I'd appreciate it if you waited to land until bug 784841 merges; that should be later this week.

::: dom/base/nsDOMClassInfo.cpp
@@ -201,5 @@
>  #include "nsIDOMHTMLObjectElement.h"
>  #include "nsIDOMTimeRanges.h"
>  #include "nsIDOMHTMLVideoElement.h"
>  #include "nsIDOMHTMLAudioElement.h"
> -#include "nsIDOMProgressEvent.h"

(Is ProgressEvent auto-generated?)

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

(In reply to :Ms2ger from comment #4) 
> I'd appreciate it if you waited to land until bug 784841 merges; that should
> be later this week.

k


> > -#include "nsIDOMProgressEvent.h"
> 
> (Is ProgressEvent auto-generated?)
Yes.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

(In reply to :Ms2ger from comment #4) 
> I'd appreciate it if you waited to land until bug 784841 merges; that should
> be later this week.
I guess I can wait a day or two.

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 719021 [details] [diff] [review]
patch

Review of attachment 719021 [details] [diff] [review]:
-----------------------------------------------------------------

Yes!

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v3

Maybe this compiles with the latest build system changes

Comment 10

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Don't forget to remove dom/interfaces/load-save/moz.build too.

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v4

Comment 12

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7cde774aa665

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7cde774aa665

Comment 14

[Kohei Yoshino [:kohei]]

I've added this bug to the compatibility doc. Please correct the info if wrong.
https://developer.mozilla.org/en-US/docs/Site_Compatibility_for_Firefox_22