845678 - [Dialer] During calling, when receiving missed call, do not show missed call notification

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Leo]

1. Title : During calling, when receiving missed call, do not show missed call notification
2. Precondition : During calling
3. Tester's Action : 
4. Detailed Symptom (ENG.) : When receiving missed incoming call, do not show missed call notifications
6. Expected : Represent missed notification during calling or after calling
7. Reproducibility: Y
1) Frequency Rate : 100%
8. Gaia revision : 6916e18d1f72936e892543cf4a104a7d457f78ad

Comment 1

[Dietrich Ayala (:dietrich)]

Hello, can you provide more clarification?

* Is a call ongoing in step #1?

* Can you provide a screenshot?

Comment 2

[Leo]

Hi ,
1st step : Yes, there is an ongoing call .
2nd       : Get an incoming call from another number and don't receive it i.e a    missed call from another number when u are already in a call .
3rd       : End the existing ongoing call
Output    :  There is no missed call notification when u are in ongoing call or even after the existing call is ended  
Expected  :  There should be a missed call notification during call or even after the call is ended 
( Android shows missed call notification while in ongoing call itself )

Comment 3

[Lucas Adamski [:ladamski]]

Lack of missed call notification is data loss per product feedback.

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/8728

Etienne, I simply handle missed calls during call waiting as the way of handling them in a normal call. Please help review the change, thanks.

Comment 5

[Etienne Segonzac (:etienne)]

Comment on attachment 727131 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/8728

We should probably modify the |addCall| function do to this and avoid the code duplication.

Something like
```
if (call.state === 'incoming') {
  // do what we do for all incoming calls (notification support...)


  // then we only branch for the different UIs
  if (handledCalls.length === 1) {
    handleFirstIncomingCall(call);
  } else {
    handleCallWaiting(call);
  }
}
```

Makes sense?

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 727131 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/8728

Etienne, I've updated the changes with your comment addressed. The new implementation avoid dup codes, however, the original one might be more readable in which it handles missed calls in 'handleXXX' functions IMHO. What do you think?

Comment 7

[Etienne Segonzac (:etienne)]

Comment on attachment 727131 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/8728

The code looks fine, just 2 nits on github.

With the comment nit addressed and once rebased the code is pretty clear :)

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks Etienne!

master: https://github.com/mozilla-b2g/gaia/commit/28da780a346f0987761ce12860a62b9464cba269

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit 28da780a346f0987761ce12860a62b9464cba269 as:
v1-train: 6522197089e14556429884074b34b60e4c78cf62