845811 - openLinkIn should use the target window's isBlankPageURL function

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

openLinkIn calls isBlankPageURL to determine whether it should raise the window and focus the location bar. isBlankPageURL returns true for about:newtab and false for about:privatebrowsing in non-private windows and vice versa in private windows. Therefore it should be called in the target window's context, as that may have a different privacy status than the current window.

Comment 1

[(no longer active)]

Comment on attachment 718968 [details] [diff] [review]
patch

Review of attachment 718968 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch!  How did you find this bug, out of curiosity?

Comment 2

[Dão Gottwald [:dao]]

(In reply to :Ehsan Akhgari from comment #1)
> Nice catch!  How did you find this bug, out of curiosity?

Just by reading the code.

Comment 3

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bc4d875f93d5

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bc4d875f93d5