846034 - label text disappears from toolbarbutton when "restore default set" is activated

Status: RESOLVED INVALID

(Toolkit :: Toolbars and Toolbar Customization, defect)

Comment 1

[u462496]

Attachment: extension demonstrating the bug

Comment 2

[u462496]

Attempting to restore the default set via the "Restore Default Set" button in the toolbar palette causes the label text of an iconless toolbar button(s) to disappear.

This happens whether the button(s) are part of the default set or not. Beginning with a fresh profile, the label text appears. The buttons may be dragged on and off of the palette without problem. But once the "Restore Default Set" is activated, the label text disappears, never to return even on restart.

Once this happens, the problem cannot be cleared except by clearing the profile.

last good:

Gecko/20091231

first bad:

Gecko/20100101

Both versions:

Mozilla/5.0
(Macintosh; U; Intel Mac OS X 10.7; en-US; rv:1.9.3a1pre) 
Minefield/3.7a1pre

Problem still exists in the latest Nightly - 22.0a1 (2013-02-27)

This testing was done on Macintosh, however the problem can be observed in Windows on FF 19.0, so presumably they are tandem.

Attached is a test case extension demonstrating the problem.  Install the extension, click on "Labodemo 3" in the Tools menu.  Window opens, click "Customize Toolbar" button.  When palette opens, click "Restore Default Set" button.  Observe the disappearance of the label text.

Comment 3

[u462496]

I am moving this to untriaged.

Comment 4

[[:Aleksej]]

Reproduced with:
* 2013-03-04-03-09-33-mozilla-central-firefox-22.0a1.en-US.linux-x86_64
* firefox-3.7a1pre.2010-01-01-03.en-US.linux-x86_64

WFM, but the "Icons"/"Icons and Text"/"Text" is set to nothing:
* firefox-3.7a1pre.2009-12-01-03.en-US.linux-x86_64
* 2009-12-31-03-mozilla-central-firefox-3.7a1pre.en-US.linux-x86_64

Comment 5

[[:Aleksej]]

That’s bug 521809, fixed by bug 537171: https://hg.mozilla.org/mozilla-central/rev/392f9ce6a71d  It is also reproducible with firefox-3.7a1pre.2009-09-01-03.en-US.linux-x86_64; in Icons mode, the text disappears, just like with the latest Nightly.

Do you want the text to be visible in the icon-only mode when there is no icon?

Comment 6

[Philip Chee]

I think this is working as designed.
    <toolbox id="LabODemoToolbox" mode="full">
Please add defaultmode="full" (or "text") to your toolbox e.g.
    <toolbox id="LabODemoToolbox" mode="full" defaultmode="full">
The customizeToolbar.js code defaults to "icons" if you don't specify a defaultmode attribute.

Comment 7

[u462496]

@Philip Chee, I agree, thank you.