846281 - Search Form Refinements

Status: RESOLVED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Joshua Smith [:joshua-s]]

Attachment: Example

This could be fixed by modifying the padding attribute on the search box.

I would like to fix this.

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Joshua Smith [:joshua-s] from comment #0)
> I would like to fix this.

It's yours!

Comment 2

[Joshua Smith [:joshua-s]]

Thanks!  Also, while we are refining the search box, do you think I should turn it and its contents into a class? (.search-form maybe?)

That would consolidate the code, and allow all search forms to use the same style.

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Joshua Smith [:joshua-s] from comment #2)
> Thanks!  Also, while we are refining the search box, do you think I should
> turn it and its contents into a class? (.search-form maybe?)
> 
> That would consolidate the code, and allow all search forms to use the same
> style.

That's a good idea. Go for it!

Comment 4

[Joshua Smith [:joshua-s]]

To work on this, do I need to delete my fork of kitsune and re-fork it? Or is there a way that I don't know about to update forked repos?

Comment 5

[Joshua Smith [:joshua-s]]

Attachment: https://support.mozilla.org/search

Should I change this form or leave it as is?

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Joshua Smith [:joshua-s] from comment #5)
> Created attachment 722900 [details]
> https://support.mozilla.org/search
> 
> Should I change this form or leave it as is?

Leave that one as is for now. Thanks

Comment 7

[Ricky Rosario [:rrosario, :r1cky]]

Landed on master:
https://github.com/mozilla/kitsune/commit/5de3c9303e2cc2e5f65b1d312667d2d7758adebb

With some tweaks:
https://github.com/mozilla/kitsune/commit/ce2a717f89d16a67ed3edb765a1e1ed8909ac076

Comment 8

[Ricky Rosario [:rrosario, :r1cky]]

Deployed to prod now.