846360 - error: expected a class or namespace: gfxImageFormat::ImageFormatRGB16_565

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Josh Matthews [:jdm]]

b56girard@112722
390 nsRefPtr<gfxImageSurface> imageSurface = new gfxImageSurface(data, size, stride, bpp == 2
b56girard@112722
391 ? gfxImageFormat::ImageFormatRGB16_565
b56girard@112722
392 : gfxImageFormat::ImageFormatARGB32);

Easy fix, just strip off the gfxImageFormat:: prefixes.

Comment 1

[Josh Matthews [:jdm]]

http://hg.mozilla.org/mozilla-central/annotate/0a91da5f5eab/gfx/thebes/gfxPlatformMac.cpp#l391

Comment 2

[Josh Matthews [:jdm]]

My mistake, we need to change gfxImageFormat:: to gfxASurface::.

Comment 3

[raul.tabacu]

I'm new to firefox development.Could you assign this to me please?

Comment 4

[raul.tabacu]

does this solve the problem?
https://github.com/Keops92/mozilla-central/commit/495ee711dae97ee46174a330d8b01fdef6795070

Comment 5

[Josh Matthews [:jdm]]

That looks right to me. Have you compiled this on OS X?

Comment 6

[raul.tabacu]

I do not have acces to OS X.Sorry.

Comment 7

[Josh Matthews [:jdm]]

Can you attach your patch to this bug?

Comment 8

[raul.tabacu]

Attachment: replaced gfxImageFormat with gfxASurface

Comment 9

[raul.tabacu]

Comment on attachment 722407 [details] [diff] [review]
replaced gfxImageFormat with gfxASurface

commit 495ee711dae97ee46174a330d8b01fdef6795070
Author: Raul <keops@Hyperion.(none)>
Date:   Wed Mar 6 10:36:19 2013 +0200

    Bug 846360-namespace modified

diff --git a/gfx/thebes/gfxPlatformMac.cpp b/gfx/thebes/gfxPlatformMac.cpp
index 6c306bb..6e354d4 100644
--- a/gfx/thebes/gfxPlatformMac.cpp
+++ b/gfx/thebes/gfxPlatformMac.cpp
@@ -388,8 +388,8 @@ gfxPlatformMac::CreateThebesSurfaceAliasForDrawTarget_hack(mozilla::gfx::DrawTar
     size_t stride = CGBitmapContextGetBytesPerRow(cg);
     gfxIntSize size(aTarget->GetSize().width, aTarget->GetSize().height);
     nsRefPtr<gfxImageSurface> imageSurface = new gfxImageSurface(data, size, stride, bpp == 2
-                                                                                     ? gfxImageFormat::ImageFormatRGB16_565
-                                                                                     : gfxImageFormat::ImageFormatARGB32);
+                                                                                     ? gfxASurface::ImageFormatRGB16_565
+                                                                                     : gfxASurface::ImageFormatARGB32);
     // Here we should return a gfxQuartzImageSurface but quartz will assumes that image surfaces
     // don't change which wont create a proper alias to the draw target, therefore we have to
     // return a plain image surface.

Comment 10

[Georgiana [:gia]]

Was this bug fixed?

Comment 11

[Josh Matthews [:jdm]]

Oops, I dropped the ball here.

Comment 12

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 722407 [details] [diff] [review]
replaced gfxImageFormat with gfxASurface

This does not seem to be a patch

Comment 13

[Josh Matthews [:jdm]]

Rahul, would you mind submitting what you posted in comment 9 as the patch here? We work in diffs instead of whole files.

Comment 14

[raul.tabacu]

Attachment: replaced gfxImageFormat with gfxASurface

Comment 15

[Josh Matthews [:jdm]]

Comment on attachment 732994 [details] [diff] [review]
replaced gfxImageFormat with gfxASurface

Thanks!

Comment 16

[Josh Matthews [:jdm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/35f98c472fb1

My apologies for the delay.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/35f98c472fb1