846551 - The unread count on the chat toolbar button is ugly and unreadable on a Mac retina screen

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Florian Quèze [:florian]]

Attachment: Screenshot of the chat toolbarbutton

See attached screenshot.

I'm not completely sure if the red circle is too large or the font size too small (or even both):
- I think the circle is too big because I think I'm supposed to still be able to see the icon
- I also think the font size is too small because the number is completely unreadable at such a small size (it's half the size in both width and height when actually displayed on the retina screen).

Comment 1

[Richard Marti (:Paenglab)]

Attachment: proposed fix

The badge is also on LoDPI to big. I've tweaked some values to let the badge be always 11px * 11px. Under OSX I made the font 0.7em instead of 0.6em.

Florian, I gave you f? to check how it looks under HiDPI.

Comment 2

[Benedikt Pfeifer]

Attachment: Screenshot of the chat toolbarbutton on Windows XP

This problem isn't limited to Macs either. The look on Windows (XP), shame on me;) is terrible too! See the Windows screenshot.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Paenglab - can you please post screenshots of the badges for each platform?

Comment 4

[Richard Marti (:Paenglab)]

Attachment: patch v2

I saw on various Linux with different font height also different badge height because of the setting of 0.6em (it varied on the different platforms between 7.2px and 7.8px). I set now a fixed height of 8px. The other changes are needed to be correct with the fixed height.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: screenshot with latest patch applied

Comment 6

[Richard Marti (:Paenglab)]

Attachment: patch v2 unbitrotted

Patch unbitrotted after landing of Bug 844599.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 729773 [details] [diff] [review]
patch v2 unbitrotted

Review of attachment 729773 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, I think this looks far far better. Thank you, Richard!

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/f601c38e6fe7