846716 - [fy-NL] Don't hardcode mobile site for wikipedia-fy-NL for Fennec Frisian

Status: RESOLVED FIXED

(Mozilla Localizations :: fy-NL / Frisian, defect)

Description

[Axel Hecht [:Pike]]

In bug 825821, we stopped hard-coding the mobile site in the wikipedia plugin, so that wp can work it's magic on whether it should show you the mobile or the desktop site.

Mind porting that change over to your localization? Milos might be able to help. We'll want a patch for the change, and get Milos to review it, or he'll just write the patch himself.

I'm filing this independent of whether we're shipping Fennec, or are close doing so.

Comment 1

[Wim]

Attachment: patch for mobile search

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch:

Comment 2

[Philip Chee]

Comment on attachment 726325 [details] [diff] [review]
patch for mobile search

Please get a review first before asking for approvals.

> [Approval Request Comment]
> Regression caused by (bug #): 
> User impact if declined: 
> Testing completed (on m-c, etc.): 
> Risk to taking this patch (and alternatives if risky):
> String changes made by this patch:

Please fill in the blanks before requesting approval

Also you need to send review/feedback requests to *someone*. I'll just guess the appropriate person is Milos Dinic:

http://blog.mozilla.org/l10n/2012/03/12/get-to-know-a-l10n-driver-milos-dinic/

Comment 3

[Wim]

Milos, can you review this before we merge?

Comment 4

[Milos Dinic [:Milos]]

Comment on attachment 726325 [details] [diff] [review]
patch for mobile search

Review of attachment 726325 [details] [diff] [review]:
-----------------------------------------------------------------

r+. Please wait for Axel's positive feedback and then push upstream with appropriate commit message, ie. mentioning this bug and our reviews.

Comment 5

[Axel Hecht [:Pike]]

Comment on attachment 726325 [details] [diff] [review]
patch for mobile search

Review of attachment 726325 [details] [diff] [review]:
-----------------------------------------------------------------

r- from my side, redirects are expensive on mobile. Please use the localized name for Special:Search, Wiki:Sykje.

Comment 6

[Wim]

Fixed in http://hg.mozilla.org/releases/l10n/mozilla-beta/fy-NL/rev/43674c26cdab