846888 - need to support swapping doc shells when only one is in a popup

Status: RESOLVED FIXED

(Core :: Web Painting, defect)

Description

[Timothy Nikkel (:tnikkel)]

Attachment: patch

In nsSubDocumentFrame::BeginSwapDocShells we assert that we are not doing this. But sadly this is a common thing to do with the addon sdk for example: opening a panel and swapping a document into the panel.

Comment 1

[Mats Palmgren (inactive)]

While you're here:
s/the current frame and all descendant frames/aFrame and its descendants/

Would it be possible to write a testcase?

The existing nsGkAtoms::listControlFrame check ... shouldn't it also check that
the frame IsInDropDownMode() ?  (maybe it doesn't matter in practice though)

Comment 2

[Timothy Nikkel (:tnikkel)]

(In reply to Mats Palmgren [:mats] from comment #1)
> The existing nsGkAtoms::listControlFrame check ... shouldn't it also check
> that
> the frame IsInDropDownMode() ?  (maybe it doesn't matter in practice though)

Good call. I fixed one case of that in bug 843979 already. I'll add a separate patch to fix that.

Comment 3

[Timothy Nikkel (:tnikkel)]

Attachment: make sure list control frames are actually popups

Comment 4

[Timothy Nikkel (:tnikkel)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0e774158e873
https://hg.mozilla.org/integration/mozilla-inbound/rev/a3d0d869bd50

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0e774158e873
https://hg.mozilla.org/mozilla-central/rev/a3d0d869bd50