Closed
Bug 846955
Opened 11 years ago
Closed 11 years ago
Argument definitions should use .define(), not str() in ClassConstructor::define
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: mccr8, Assigned: mccr8)
References
Details
Attachments
(1 file)
|
1.05 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
Bug 839088 changed Argument to require the use of .declare() and .define() instead of str(), but didn't change all of the places that should use .define(). I came across this with my example JS implementation, where constructor arguments ended up coming out like |<Codegen.Argument instance at 0x1007477a0>|.
|
Assignee | |
Comment 1•11 years ago
|
||
It looks like this is only a problem in one place. I audited the code using the scientific approach of looking for places that used "args" and places that did "str(a", and didn't find anything else.
|
|
Assignee | |
Updated•11 years ago
|
Summary: Argument definitions should use .define(), not str() → Argument definitions should use .define(), not str() in ClassConstructor::define
|
|
Assignee | |
Updated•11 years ago
|
Attachment #720186 -
Flags: review?(bzbarsky)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 720186 [details] [diff] [review] fix ClassConstructor::define Oops. r=me
Attachment #720186 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d0f2cba284a
|
||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1d0f2cba284a
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•