847202 - Convert SVGFEMergeNodeElement to WebIDL

Status: RESOLVED FIXED

(Core :: SVG, defect)

Comment 1

[David Zbarsky (:dzbarsky)]

Attachment: Patch

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 720478 [details] [diff] [review]
Patch

Review of attachment 720478 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/svg/content/src/SVGFEMergeElement.cpp
@@ +66,2 @@
>      if (node) {
> +      aSources.AppendElement(nsSVGStringInfo(node->GetIn1(), node));

I think it would make more sense to write this as

for () {
  if (child->IsSVG(nsGkAtoms::feMergeNode)) {
    SVGFEMergeNodeElement* element = static_cast<SVGFEMergeNodeElement*>(child);
    aSources.AppendElement(nsSVGStringInfo(element->GetIn1(), node));
  }
}

::: content/svg/content/src/nsSVGFilters.cpp
@@ +10,2 @@
>  
> +namespace mozilla {

> NS_NewSVGFEMergeNodeElement(nsIContent **aResult,

* to the left (x2)

@@ +13,3 @@
>  
> +JSObject*
> +SVGFEMergeNodeElement::WrapNode(JSContext *aCx, JSObject *aScope, bool *aTriedToWrap)

> SVGFEMergeNodeElement::WrapNode(JSContext *aCx, JSObject *aScope, bool *aTriedToWrap)

* to the left

@@ +30,5 @@
>  
> +NS_INTERFACE_TABLE_HEAD(SVGFEMergeNodeElement)
> +  NS_NODE_INTERFACE_TABLE3(SVGFEMergeNodeElement, nsIDOMNode, nsIDOMElement,
> +                           nsIDOMSVGElement)
> +NS_INTERFACE_MAP_END_INHERITING(SVGFEMergeNodeElementBase)

If I asked you to use NS_IMPL_NSISUPPORTS_INHERITED* before, I guess that misses the _NODE_ part of NS_NODE_INTERFACE_TABLE, so ignore these comments.

@@ +30,5 @@
>  
> +NS_INTERFACE_TABLE_HEAD(SVGFEMergeNodeElement)
> +  NS_NODE_INTERFACE_TABLE3(SVGFEMergeNodeElement, nsIDOMNode, nsIDOMElement,
> +                           nsIDOMSVGElement)
> +NS_INTERFACE_MAP_END_INHERITING(SVGFEMergeNodeElementBase)

> SVGFEMergeNodeElement constructor

{}s on their own line

@@ +30,5 @@
>  
> +NS_INTERFACE_TABLE_HEAD(SVGFEMergeNodeElement)
> +  NS_NODE_INTERFACE_TABLE3(SVGFEMergeNodeElement, nsIDOMNode, nsIDOMElement,
> +                           nsIDOMSVGElement)
> +NS_INTERFACE_MAP_END_INHERITING(SVGFEMergeNodeElementBase)

> virtual JSObject* WrapNode(JSContext *cx, JSObject *scope, bool *triedToWrap) MOZ_OVERRIDE;

* to the left and aFoo

Comment 3

[David Zbarsky (:dzbarsky)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7e854664b2ad

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7e854664b2ad