847264 - Need to add customizing power off animation.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[KM Lee [:rexboy] (inactivate after Sep. 22)]

We need to implement customizing poweroff animation.

Customizing power on animation has been implemented in bug 838104.  For poweroff, same format (png and mp4) would be allowed as far.

Peter, may you suggest that if we want to allow partners to customize poweroff animation, shall it just replace the original one (the three rings) or let these two animations appear in sequence?
Thanks for the help!

Comment 1

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: Patch

Partners should put their customized poweroff logo at
<CUSTOMIZE DIR>/power/carrier_power_off.png or
<CUSTOMIZE DIR>/power/carrier_power_off.mp4

I found that mozPower can't be replaced with mock, so the unit test is now just for the logo loader.

Tim, may you review this patch?  Thanks for the help!

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 721125 [details]
Patch

please fix some nits before merge!

Comment 3

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Thanks for reviewing Tim!  Mistakes are fixed.

merged here:
https://github.com/mozilla-b2g/gaia/commit/d126a77d90c98a25c48ba34d43e59cbf97c565e2

It's still tef?.  If it's marked tef+ later, I will uplift it to v1-train and 1.0.1 branch.

Comment 4

[KM Lee [:rexboy] (inactivate after Sep. 22)]

v1-train
https://github.com/mozilla-b2g/gaia/commit/067c040f3f16d5660ab1e117abf0834f1509d6f3

v1.0.1
https://github.com/mozilla-b2g/gaia/commit/f03bc0e8647f94ab133fe813d68500061c147681

Comment 5

[Peter La]

(In reply to KM Lee [:rexboy] from comment #0)
> We need to implement customizing poweroff animation.
> 
> Customizing power on animation has been implemented in bug 838104.  For
> poweroff, same format (png and mp4) would be allowed as far.
> 
> Peter, may you suggest that if we want to allow partners to customize
> poweroff animation, shall it just replace the original one (the three rings)
> or let these two animations appear in sequence?
> Thanks for the help!

Hi rexboy, sorry for the late response.  My recommendation is that if you allow customization, it should replace the existing one.  Appending it to the existing 3 rings would make the customization almost pointless.

Comment 6

[KM Lee [:rexboy] (inactivate after Sep. 22)]

(In reply to Peter La from comment #5)
> (In reply to KM Lee [:rexboy] from comment #0)
> Hi rexboy, sorry for the late response.  My recommendation is that if you
> allow customization, it should replace the existing one.  Appending it to
> the existing 3 rings would make the customization almost pointless.
OK, that's certainly what we do in this patch.
Thanks for reply!

Comment 7

[Cody Roesch [:croesch]]

Can you please provide steps to verify this fix - as we will blackbox test from the UI?

Comment 8

[Darren]

Edited an already existing but to make sure people look for the animation when powering off.
https://moztrap.mozilla.org/manage/cases/?filter-id=1330

Comment 9

[amiller]

This issue appears to be fixed on Unagi device
Build ID: 20130402070202
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/ccec751a468e
Gaia: ee0bef61c0a25c806dd1eec5a4e047bc418a5f73

also, issue appears fixed on build 20130402070204
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/68c8a883cfc0
Gaia: 1c38c91bb16f2bf0d5066c4787d2249463f61bb3

Animation works properly.

Comment 10

[Alissa（leave from Mozilla）]

According to comment9,delete keywords verifyme.