Closed
Bug 847316
Opened 11 years ago
Closed 11 years ago
Remove some unused code in the clock app - again
Categories
(Firefox OS Graveyard :: Gaia::Clock, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: vingtetun, Unassigned)
Details
Attachments
(3 files)
7.31 KB,
patch
|
etienne
:
review+
akeybl
:
approval-gaia-v1-
|
Details | Diff | Splinter Review |
35.91 KB,
image/png
|
Details | |
15.06 KB,
image/png
|
Details |
This save a few (hundreds?) ms. I kept the background in the images/ folder but it is not used and this is really invisible on the device.
Attachment #720584 -
Flags: review?(etienne)
Comment 1•11 years ago
|
||
Comment on attachment 720584 [details] [diff] [review] Patch Review of attachment 720584 [details] [diff] [review]: ----------------------------------------------------------------- r=me with the color code corrected and the proper image removal. ::: apps/clock/style/clock.css @@ +15,2 @@ > #views { > + background: #131414; This should be #101111
Attachment #720584 -
Flags: review?(etienne) → review+
Comment 2•11 years ago
|
||
Comment 3•11 years ago
|
||
Reporter | ||
Comment 4•11 years ago
|
||
(In reply to Etienne Segonzac (:etienne) from comment #1) > Comment on attachment 720584 [details] [diff] [review] > Patch > > Review of attachment 720584 [details] [diff] [review]: > ----------------------------------------------------------------- > > r=me with the color code corrected and the proper image removal. > > ::: apps/clock/style/clock.css > @@ +15,2 @@ > > #views { > > + background: #131414; > > This should be #101111 My gimp skills has failed :(
Reporter | ||
Comment 5•11 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/50a39c3d2157f266f16b9efb3388f4cec366414a
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 6•11 years ago
|
||
Comment on attachment 720584 [details] [diff] [review] Patch NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. The patch is mostly of removals of css unused / useless things and does not add any logic changes.
Attachment #720584 -
Flags: approval-gaia-v1?(akeybl)
Comment 7•11 years ago
|
||
(In reply to Vivien Nicolas (:vingtetun) (:21) from comment #4) > My gimp skills has failed :( Or maybe it's because your laptop still has gimp 1.4 ;)
Comment 8•11 years ago
|
||
Comment on attachment 720584 [details] [diff] [review] Patch We typically don't take code cleanup on branches, since it has little value but does have risk of regression. Please re-nominate if there's a particularly good reason (for instance, difficult merge conflicts).
Attachment #720584 -
Flags: approval-gaia-v1?(akeybl) → approval-gaia-v1-
You need to log in
before you can comment on or make changes to this bug.
Description
•