Closed
Bug 847515
Opened 11 years ago
Closed 7 years ago
Profile UI Performance to find bottlenecks and low hanging fruit for optimization
Categories
(Firefox for Metro Graveyard :: Theme, defect)
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
People
(Reporter: ally, Unassigned)
References
Details
(Whiteboard: [defect] p=0)
We have a whole bunch of descendant selectors, which are very expensive and very bad for performance. We should try to purge platform.css of all of them.
Comment 1•11 years ago
|
||
The highest-priority ones are where the principal selector is very broad and does not use a class or ID, for example: http://hg.mozilla.org/mozilla-central/file/0a91da5f5eab/browser/metro/theme/platform.css#l362 That one is really bad because the cost of matching the descendant selector will be incurred for every <description> element in the entire app. When the principal selector is narrower, like this, the cost is much more limited and we should fix it only if it won't make our code much more fragile or complex: http://hg.mozilla.org/mozilla-central/file/0a91da5f5eab/browser/metro/theme/platform.css#l366
Updated•11 years ago
|
Blocks: metrov1triage
Updated•11 years ago
|
Component: General → Theme
Comment 2•11 years ago
|
||
I think this is a good bug to do but I don't think it belongs in any story and I don't think it causes any human-noticeable jank, so I'm going to remove it from v1 triage. But feel free to work on it when you have time.
No longer blocks: metrov1triage
Updated•11 years ago
|
Blocks: metrov2planning
Updated•11 years ago
|
Blocks: metrobacklog
Updated•11 years ago
|
No longer blocks: metrov2planning
Updated•10 years ago
|
Whiteboard: [defect] p=0
Comment 3•10 years ago
|
||
I'm re-titling this bug. Changing selectors may or may not be a useful performance optimization, and may incur maintenance and reuse-potential costs. First we need to identify problems before prescribing fixes, so I suggest we use this bug for that work.
Summary: Death to Descendant Selectors → Profile UI Performance to find bottlenecks and low hanging fruit for optimization
Comment 4•7 years ago
|
||
Mass close of bugs in obsolete product https://bugzilla.mozilla.org/show_bug.cgi?id=1350354
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INCOMPLETE
You need to log in
before you can comment on or make changes to this bug.
Description
•