847630 - VectorImage doesn't need to defer OnStopRequest anymore

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Seth Fowler [:seth] [:s2h]]

Since bug 841579 landed, it should now be the case that things don't blow up if all decoding isn't complete by the time LOAD_COMPLETE is sent to nsImageLoadingContent. That means the code added for bug 704059 which deferred the arrival of OnStopRequest for VectorImages until the underlying document was ready is probably redundant now. Let's rip that out and keep things as simple as possible.

Comment 1

[Seth Fowler [:seth] [:s2h]]

Attachment: Stop deferring OnStopRequest in VectorImage.

Proposed patch. Try job here: https://tbpl.mozilla.org/?tree=Try&rev=b920b9632166

Comment 2

[Seth Fowler [:seth] [:s2h]]

OK, nothing appears to have broken. Now for a broader test to see if we start hitting test_animSVGImage mochitest failures frequently again.

Try job here: https://tbpl.mozilla.org/?tree=Try&rev=ee66def6285b

Comment 3

[Seth Fowler [:seth] [:s2h]]

Alright, I'm happy. Pushed in:

https://hg.mozilla.org/integration/mozilla-inbound/rev/e2cdf49fe873

Comment 4

[Seth Fowler [:seth] [:s2h]]

Ack, just realized that I never actually requested review for this, even though the patch says r=joe. Joe, I'm gonna go ahead and request review anyway; if you find any issues I'll just create a followup patch to fix them or back the patch out. Sorry for the screwup.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e2cdf49fe873