847974 - Have Java install from PFS link to a SUMO page instead of providing Java installs directly

Status: RESOLVED FIXED

(Toolkit Graveyard :: Plugin Finder Service, defect, P1)

Description

[Benjamin Smedberg]

PFS currently links Windows users directly to java installers. It also links other users directly to the Oracle download page. I would like instead to always link users to our SUMO page about Java, so that we can warn users about ongoing Java security issues before they download something they may not need/want.

Comment 1

[Benjamin Smedberg]

<Tyler> bsmedberg: if you want to use HTTPS, use https://support.mozilla.org/kb/use-java-plugin-to-view-interactive-content
<Tyler> that's language and OS independent

Comment 2

[Benjamin Smedberg]

https://github.com/mozilla/zamboni/pull/655 with r?clouserw and tyler

Comment 3

[Wil Clouser [:clouserw]]

Landed on -dev.  Please QA

Comment 4

[juan becerra [:juanb]]

Could anyone point me to testing instructions? I tried changing an about config pref pointing to pfs.mozilla.org to the dev allizom url, but I can't trigger the dialog to come up.

Also, should the Java link in https://www.mozilla.org/en-US/plugincheck/ point to the SUMO support page?

Comment 5

[Wil Clouser [:clouserw]]

Krupa might know about testing instructions

Comment 6

[juan becerra [:juanb]]

I haven't been able to trigger the dialog after replacing:

pfs.mozilla.org/plugins/PluginFinderService.php

With:

addons-dev.allizom.org/services/pfs.php

As described in https://wiki.mozilla.org/PFS#Testing_PFS

Cc'ing a couple of people who have tested this in the past.

Comment 7

[Carsten Book [:Tomcat]]

(In reply to juan becerra [:juanb] from comment #6)
> I haven't been able to trigger the dialog after replacing:
> 
> pfs.mozilla.org/plugins/PluginFinderService.php
> 
> With:
> 
> addons-dev.allizom.org/services/pfs.php
> 
> As described in https://wiki.mozilla.org/PFS#Testing_PFS
> 
> Cc'ing a couple of people who have tested this in the past.


Testing steps for pfs should be easy:
-> Make sure you have a clean system without java!
-> Go to a java test page
-> The yellow infobar should be popup informing you that a plugin is missing for the content of the page

Comment 8

[Alice Wyman]

How is related to Bug 836420 - Remove PFS from Firefox ?

Comment 9

[Alice Wyman]

How is this related to Bug 836420 - Remove PFS from Firefox ?

... and to Bug 836415 - Kill PFS ?

Comment 10

[Benjamin Smedberg]

Tomcat, the question is mainly about how we test this on -dev before it gets pushed to production. If I visit https://addons-dev.allizom.org/services/pfs.php?mimetype=application/x-java-vm&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=20130303030835&clientOS=Windows+NT+6.1&chromeLocale=en directly, it redirects to pfs.mozilla.org, so I can't test staging in a useful way.

Alice, this is an immediate/short-term fix to the existing PFS, and doesn't affect the slightly longer-term PFS-removal bugs.

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Both https://www-dev.allizom.org/en-US/plugincheck/ and https://www.allizom.org/en-US/plugincheck/ call out to:

plugins.stage.mozilla.com:

[14:45:10.197] GET https://plugins.stage.mozilla.com/pfs/v2?appID=%7Bec8030f7-c20a-464f-9b0e-13a3a9e97384%7D&appRelease=22.0&appVersion=20130306031012&clientOS=Windows+NT+6.1%3B+WOW64&chromeLocale=en-US&detection=original&mimetype=application%2Fjava-deployment-toolkit&callback=C [HTTP/1.1 200 OK 38ms]

So I think something in the app/Apache configs itself will have to change.

pmac, cmore, espressive -- know how we can either push to PFS stage, and/or also get the changes from comment 2 showing up on dev?

Comment 12

[Lukas Blakk [:lsblakk] use ?needinfo]

In channel meeting today Juan stated that Krupa did not have a way to test this so flagging cmore and pmac to see if we can get an answer to the questions in comment 11.  

Bsmedberg - what is the urgency of this issue?  We're not tracking it for FF20 - what timeline does this need to have?

Comment 13

[Chris More [:cmore]]

A new version of the plugin check page is being created in bug 797192. 

espressive/pmac: Can you comment?

Comment 14

[Paul [:pmac] McLanahan]

If the changes need to happen on plugins.stage.mozilla.org then that's Laura's team. I'll see if she knows how we can proceed.

Comment 15

[Benjamin Smedberg]

This is "yesterday" urgent. I really don't understand what the hangup is about this; we push Flash PFS updates without any stage all the time, from what I can tell. Can we just push this to production please!?

Comment 16

[Schalk Neethling [:espressive]]

Yeah so, this is a change that is needed on the PFS (plugins.mozilla.com) side. The plugincheck page just displays/links whatever it gets back from PFS. There is no need to wait for the new plugincheck page in order to make this change, that I can think of.

Comment 17

[Schalk Neethling [:espressive]]

Oh, and Tomcat is out until the 1st of April I believe so, not sure who can make changes on the production box.

Comment 18

[Brandon Savage [:brandon]]

Looks like this bug took a serious left turn around Comment 13.

PFS is different from PFS2 and different from plugin check.

PFS is a service hosted on AMO which is part of Zamboni. Bsmedberg's changes relate only to that service, which is something Firefox uses. We do not, as far as I can tell, need to update plugins.m.o.

The challenge seems to be that we need to find a way to QA the change to ensure the behavior is what we expect. This is proving challenging. And this change is somewhat urgent.

Comment 19

[Wil Clouser [:clouserw]]

AMO code goes out every Thursday.  This has been live for two weeks.  If it's not doing what you want, the patch from comment 2 wasn't correct.

Comment 20

[Benjamin Smedberg]

ok thanks. That was certainly not clear that the -dev push didn't need another step.