848051 - Allow 'arguments' in generator-expressions

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

Generator expressions should inherit 'arguments' from the enclosing lexical scope just like any other name. ...Right? (This turns out to be ridiculously easy to implement. Embarrassed I didn't do it earlier. It just needs some tests.)

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: v1

Comment 2

[Eddy Bruel [:ejpbruel]]

Comment on attachment 721506 [details] [diff] [review]
v1

Review of attachment 721506 [details] [diff] [review]:
-----------------------------------------------------------------

So if I'm reading this patch right, all you had to do was *not* throw an error if a generator expression has arguments as a lexical dependency? That's pretty simple, indeed :-)

Anyway, the fix is trivial, and looks well tested, so really I have nothing to add here. r+

Comment 3

[Jason Orendorff [:jorendorff]]

I had to change some existing tests to get this through try server -- all of them were specifically testing that 'arguments' was a SyntaxError in a generator-expression.

https://hg.mozilla.org/integration/mozilla-inbound/rev/4cb73e976b28

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4cb73e976b28

Comment 5

[Tooru Fujisawa [:arai]]

Updated following document:
  https://developer.mozilla.org/en-US/Firefox/Releases/22