848180 - tab and window module related test failures on Fennec due to pb updates

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

tests/test-private-browsing.testIsPrivateOnTab: failure, exception
tests/test-private-browsing.testWindowDefaults: exception
tests/test-tabs-common.testPrivateAreNotListed: failure

Comment 1

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Convince me this is a 1.14 bug.

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

I think I broke a module used only on Fennec in a private browsing bug that would has landed on stabilization, so there would be a regression.  I think the tests themselves may be fine.

Comment 3

[Jeff Griffiths (:canuckistani) (:⚡︎)]

What's the impact of the regression then, do we completely fail on fennec?

Comment 4

[Erik Vold [:erikvold] (please needinfo? me)]

ok it looks like only window.isPrivate was broken on Fennec, and the ptpb tests were also broken.  So it's not huge, but I've got a patch now.

Comment 5

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/843

Pointer to Github pull-request

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/c36e2779d74ccfed146ae7ddd0d920e2c774eeb4
Bug 848180: fixing ptpb tests on Fennec and a minor regression where window.isPrivate would fail on Fennec

https://github.com/mozilla/addon-sdk/commit/214b6737249feee783e05bb060160fde60db833c
Merge pull request #843 from erikvold/848180

Fix Bug 848180: fixing ptpb tests and window.isPrivate on Fennec r=@ochameau

Comment 7

[[github robot]]

Commit pushed to stabilization at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/d8cdc07ea821aa8fecfd8ef9320ae25839b8336d
Merge pull request #843 from erikvold/848180

Fix Bug 848180: fixing ptpb tests and window.isPrivate on Fennec r=@ochameau(cherry picked from commit 214b6737249feee783e05bb060160fde60db833c)