848421 - image-rendering: -moz-crisp-edges gets lost on html background image if body is display: none

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[(not currently active) Ted Mielczarek]

Attachment: testcase

The attachment is a HTML page with a background-image on the html element, with background-size: cover, and image-rendering: -moz-crisp-edges; The background image is a 2x2 white and black checkerboard (for maximum effect).

It should render as a crisp 2x2 checkerboard, but we lose the -moz-crisp-edges if the body element has display:none. If you remove display:none from body it works as expected.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: expected

This is the same page as the testcase, with display:none removed from the body element. It renders as expected.

Comment 2

[Timothy Nikkel (:tnikkel)]

Attachment: patch

FindBackgroundStyleFrame just looks for the frame for the body element. Just use FindBackground like we go everywhere else, it does it right.

Comment 3

[Timothy Nikkel (:tnikkel)]

Attachment: remove a prescontext argument, cleanup

Comment 4

[Timothy Nikkel (:tnikkel)]

Attachment: reftest

Comment 5

[Timothy Nikkel (:tnikkel)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/362ac27b9de0
https://hg.mozilla.org/integration/mozilla-inbound/rev/c2e60fc5e817

I'll land the cleanup patch later when it gets review, but this bug can close when these merge.

Comment 6

[Timothy Nikkel (:tnikkel)]

Ted, where did you come across this testcase? Is this something we might want to uplift?

Comment 7

[(not currently active) Ted Mielczarek]

I found this bug while adding an easter egg to http://people.mozilla.org/~catlee/highscores/highscores.html

It was driving me nuts so I manually reduced the testcase. It seems like a pretty minor edgecase, it's probably not worth worrying about.

Comment 8

[(not currently active) Ted Mielczarek]

(Thanks for fixing it, though!)

Comment 9

[Mats Palmgren (inactive)]

Comment on attachment 722005 [details] [diff] [review]
remove a prescontext argument, cleanup

r=mats

Comment 10

[Timothy Nikkel (:tnikkel)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/98e3a2192918

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/362ac27b9de0
https://hg.mozilla.org/mozilla-central/rev/c2e60fc5e817

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/98e3a2192918