849200 - [REGRESSION] Removing workaround about 'hold-home' during FTU it's not working with PIN CODE

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Comment 1

[Borja Salguero [:borjasalguero]]

After bug 814840 we have a regression when PIN Code it's required by SIM Card. This is due to here https://github.com/mozilla-b2g/gaia/commit/449c2c10f388c08cc9b63a84b18c2da312b357b8#L6R42 we are requesting a method FtuLauncher.getFtuOrigin() which it's not working as expected.

In a first sight it's not working due to in that method you have https://github.com/mozilla-b2g/gaia/commit/449c2c10f388c08cc9b63a84b18c2da312b357b8#L3R24 . However, when you return '_ftuURL' this it's not set yet! This is due to you are setting this param inside an 'asyncStorage' https://github.com/mozilla-b2g/gaia/commit/449c2c10f388c08cc9b63a84b18c2da312b357b8#L3R98 , and it takes around 1 second. That's why '_ftuURL' it's not set properly, and instead of having the standalone SIM screen of FTU App, we are showing the common PIN CODE screen one due to condition it's not working as expected.
https://github.com/mozilla-b2g/gaia/commit/449c2c10f388c08cc9b63a84b18c2da312b357b8#L6R42

I dont know if it's better to fix this or backout your commit, make the modification needed and review it again.

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

I will fix it.

Comment 3

[Borja Salguero [:borjasalguero]]

Thanks! ;)

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/8560

The original logic in SimLock.js works because: Ftu was running upon lockscreen before. And Sim Pin Dialog would skip if LockScreen is locked.

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

master https://github.com/mozilla-b2g/gaia/commit/42c94d81bc61ea91013bad66286013c4a7ff8ed2