849612 - Fix build problems caused by Bug 847195 [error: nsIDOMNamedNodeMap.h: No such file or directory]

Status: RESOLVED FIXED

(MailNews Core :: Composition, defect)

Description

[Frank Wein [:mcsmurf]]

It looks like Bug 847195 removed the nsIDOMNamedNodeMap class, due to that build failure(s?) occur, from SeaMonkey build log:
[...]
/builds/slave/c-cen-t-lnx-ntly/build/mailnews/compose/src/nsMsgCompose.cpp:17:32: fatal error: nsIDOMNamedNodeMap.h: No such file or directory
[...]

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

I changed the code to use more well-supported APIs, because there's a good chance I'd break this code again soon if I didn't.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1.1

With build errors fixed.

Comment 3

[Frank Wein [:mcsmurf]]

Actually I think those two guys are better reviewers for this :)

Comment 4

[:aceman]

Why isn't msgCompose changed to use nsDOMMozNamedAttrMap.h as the files in the respective mozilla.central patch? It appears to me the mozilla namespace adds quite a lot of compile time. But I haven't benchmarked it precisely.

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

No idea what you're talking about with the compile time. The reason I'm not using nsIDOMMozNamedAttrMap is because I want to kill that interface.

Comment 6

[[e-mail]]

Comment on attachment 723194 [details] [diff] [review]
Patch v1.1

Although by default mailnews gets linked into libxul I'd appreciate it if you avoided libxul-only code so that it can build against xulrunner.

Comment 7

[[e-mail]]

Attachment: Possible patch

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 723385 [details] [diff] [review]
Possible patch

Review of attachment 723385 [details] [diff] [review]:
-----------------------------------------------------------------

This would work for now, yes.

Comment 9

[Mark Banner (:standard8)]

Comment on attachment 723385 [details] [diff] [review]
Possible patch

Review of attachment 723385 [details] [diff] [review]:
-----------------------------------------------------------------

Seems reasonable to me.

Comment 10

[[e-mail]]

Pushed comm-central changeset 7bf5abf3214d.

Comment 11

[:aceman]

Do we obsolete the patch v1.1 or is that open for a way to fix this in a different way in the future?

Comment 12

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 723194 [details] [diff] [review]
Patch v1.1

This won't work at this point.