Closed
Bug 849737
Opened 11 years ago
Closed 11 years ago
all unit tests failed since travis switched to 64bit VM
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 fixed)
RESOLVED
FIXED
People
(Reporter: yurenju, Assigned: yurenju)
References
Details
Attachments
(1 file)
all unit tests failed since travis got 64bit VM https://travis-ci.org/mozilla-b2g/gaia/pull_requests we need to download 64bit firefox instead of 32bit.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #723356 -
Flags: review?(timdream)
Comment 2•11 years ago
|
||
Comment on attachment 723356 [details] PR: https://github.com/mozilla-b2g/gaia/pull/8563 r=me. I hate the build is failed message so I steal the review. BTW what's the sms fix here? If it's not relevant to this issue, I recommend to put it in another bug.
Attachment #723356 -
Flags: review?(timdream) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Sure, merged without fixing sms unit test. https://github.com/mozilla-b2g/gaia/commit/b398be093a4e2d62326023764d6eea1faf2acb49
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 5•11 years ago
|
||
Comment on attachment 723356 [details] PR: https://github.com/mozilla-b2g/gaia/pull/8563 NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: unit tests failed on travis for v1-train & v1.0.1 Testing completed: Risk to taking this patch (and alternatives if risky): None String or UUID changes made by this patch:
Attachment #723356 -
Flags: approval-gaia-v1?(21)
Assignee | ||
Updated•11 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 6•11 years ago
|
||
reopen since we have same problem on v1-train & v1.0.1
Comment 7•11 years ago
|
||
Correct flags.
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
status-b2g18:
--- → affected
status-b2g18-v1.0.0:
--- → wontfix
status-b2g18-v1.0.1:
--- → affected
Resolution: --- → FIXED
Comment 8•11 years ago
|
||
Who could approval-gaia-v1? when Vivien is on vacation?
Comment 9•11 years ago
|
||
I might as well as raise this issue to tef+, it will be faster than approval :-/
blocking-b2g: --- → leo?
Updated•11 years ago
|
blocking-b2g: leo? → tef?
Comment 10•11 years ago
|
||
just land it with a=npotb, right ?
Comment 11•11 years ago
|
||
Hey, I'll land it myself :)
Comment 12•11 years ago
|
||
a=npotb v1-train: 8e9008e80876d4769a085ed0e0c3fe8350fe3036 v1.0.1: a6a0a120e45f7244341315e1b478f0736a09cd6a
Updated•11 years ago
|
Attachment #723356 -
Flags: approval-gaia-v1?(21)
Comment 13•11 years ago
|
||
Thanks!!
You need to log in
before you can comment on or make changes to this bug.
Description
•