Closed
Bug 849905
Opened 11 years ago
Closed 11 years ago
bug filing links in my dashboard should be able to be opened in new tabs/windows
Categories
(bugzilla.mozilla.org :: MyDashboard, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bhearsum, Assigned: dkl)
Details
Attachments
(1 file)
5.12 KB,
patch
|
glob
:
review+
|
Details | Diff | Splinter Review |
Eg, middle click or ctrl-click or maybe ctrl-enter. Right now there's no way that I can find to open them in any window except the current window. It's a little weird since the dashboard seems to be intended to stay open for long periods of time.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → dkl
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•11 years ago
|
||
Had to quite a bit of refactoring to add a new 'new_tab' config option to ProdCompSearch. But this makes the extension more configurable than before. Dashboard will open a new tab whereas guidedbugentry, product chooser, etc. will not. dkl
Attachment #723671 -
Flags: review?(glob)
Comment on attachment 723671 [details] [diff] [review] Patch to open new tab when selecting prod/comp from search (v1) Review of attachment 723671 [details] [diff] [review]: ----------------------------------------------------------------- r=glob ::: extensions/BMO/template/en/default/global/choose-product.html.tmpl @@ +62,5 @@ > [% PROCESS prodcompsearch/form.html.tmpl > + input_label = "Find product:" > + format = format > + cloned_bug_id = cloned_bug_id > + script_name = target please indent the parameters ::: extensions/GuidedBugEntry/template/en/default/guided/guided.html.tmpl @@ +119,5 @@ > <div id="prod_comp_search_main"> > [% PROCESS prodcompsearch/form.html.tmpl > input_label = "Find product:" > + format = "guided" > + script_name = "enter_bug.cgi" please indent the parameters ::: extensions/MyDashboard/template/en/default/pages/mydashboard.html.tmpl @@ +105,5 @@ > <div id="prod_comp_search_main"> > [% PROCESS prodcompsearch/form.html.tmpl > + input_label = "File a $terms.Bug:" > + script_name = "enter_bug.cgi" > + new_tab = 1 please indent the parameters ::: extensions/ProdCompSearch/web/js/prod_comp_search.js @@ +98,5 @@ > if (ProdCompSearch.cloned_bug_id) > url += "&cloned_bug_id=" + encodeURIComponent(ProdCompSearch.cloned_bug_id); > } > + if (ProdCompSearch.new_tab) { > + window.open(url, '_blank'); you should probably clear the search field at this point.
Attachment #723671 -
Flags: review?(glob) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bmo/4.2 modified extensions/BMO/template/en/default/global/choose-product.html.tmpl modified extensions/ProdCompSearch/template/en/default/prodcompsearch/form.html.tmpl modified extensions/MyDashboard/web/js/query.js modified extensions/ProdCompSearch/template/en/default/pages/prodcompsearch.html.tmpl modified extensions/ProdCompSearch/web/js/prod_comp_search.js modified extensions/MyDashboard/template/en/default/pages/mydashboard.html.tmpl modified extensions/GuidedBugEntry/template/en/default/guided/guided.html.tmpl Committed revision 8682.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•