850259 - Mozillians Privacy Controls: L10N review

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Justin Crawford [:hoosteeno] [:jcrawford]]

We have a goal this quarter to launch a small new featureset on Mozillians that will include a handful of new strings. 

Our project will create the possibility that Mozillians users can make certain fields on their profiles more public. You can read all about it here:

https://wiki.mozilla.org/Mozillians/Releases/Privacy_Controls

The strings are under development here:

https://mozillians.etherpad.mozilla.org/privacy-controls-strings

These strings will fit into the L10N workflow already established, and there aren't very many. So our plan is to just run a string merge to get them into Verbatim as soon as they're ready. However, :pascalc asked that we send him a link to the staged site and a link to the strings so he can review before we run a string merge.

Comment 1

[Justin Crawford [:hoosteeno] [:jcrawford]]

Nearly all of the strings have landed in our Privacy Controls staging area.

Here are the final strings:

https://mozillians.etherpad.mozilla.org/privacy-controls-strings

Here is the staging area:

https://mozillians-dev.allizom.org/en-US/user/edit

One string (the first one on the etherpad) is in a PR, and will be deployed very soon:

https://github.com/mozilla/mozillians/pull/437/files

Comment 2

[Pascal Chevrel:pascalc]

Pull request 437 does not cause any l10n problem, but that bug is in the wrong component as it is not a www.mozilla.org bug

Comment 3

[Justin Crawford [:hoosteeno] [:jcrawford]]

I'm changing the component.

Pull request 437 is only one of many changes described in the etherpad linked in comment 1. Except for pull request 437, all of the other changes are deployed to the staging area linked in comment 1. 

Thanks!

Comment 4

[Pascal Chevrel:pascalc]

Do you have pointers to the pull requests that added strings corresponding to the demo server?

Comment 5

[Justin Crawford [:hoosteeno] [:jcrawford]]

I'm digging through the commits to the privacy branch of mozilla/mozillians. The below commits include many of the string changes:

https://github.com/mozilla/mozillians/commit/21584661955e163d446bf43bf225733917113d07

https://github.com/mozilla/mozillians/commit/87cd46813391939c22776de491d9e0d2f612bb18

https://github.com/mozilla/mozillians/commit/a8357fe05614368fabaf4087be695c9937b9601b

https://github.com/mozilla/mozillians/commit/46a063149c4f1c8ca96d2fa286b27539b8eb22f7

https://github.com/mozilla/mozillians/commit/d0a2273558cec157e022fc3642c1efa96812b12c

Comment 6

[Pascal Chevrel:pascalc]

Everything looks good except this one:
https://github.com/mozilla/mozillians/commit/d0a2273558cec157e022fc3642c1efa96812b12c

+            <option value="#">-- View as --</option>
+            <option value="public">Public</option>
+            <option value="mozillians">Mozillians</option>
+            <option value="all">All</option> 

The value options are not enclosed in l10n calls.

Comment 7

[Justin Crawford [:hoosteeno] [:jcrawford]]

Great!

https://github.com/mozilla/mozillians/commit/085ba2a0d5388677bb17d6861e0ed64beb03b0cb

Comment 8

[[github robot]]

Commit pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/8d9e3d8c2358c1dc3eb120dc8ecbd3dd2f0e1544
[bug 850259] Translate strings

Comment 9

[Justin Crawford [:hoosteeno] [:jcrawford]]

The new Mozillians privacy controls are in staging and tagged for a 3/28 release. 

https://mozillians.allizom.org/en-US/user/edit/

Comment 10

[Justin Crawford [:hoosteeno] [:jcrawford]]

Pascal, is there any more L10N review, or is this bug resolved? Thanks!

Comment 11

[Pascal Chevrel:pascalc]

From a purely strings point of view, I think we are good, but I am noticing in the site a couple of things that bother me a bit:
* The checkboxes that says something like 'I accept that you keep my data as explained in Mozilla privacy policy" has no link to the privacy policy, if the link is to be added later, you have to make sure that the string has the relevant part of the text to be linked marked up.

* The list of countries does not seem to be localized, if it is localizable, please import the country names from Firefox source code for consistency and so as to avoid having hundreds (tedious) more strings to translate.

Comment 12

[Justin Crawford [:hoosteeno] [:jcrawford]]

Great, then I'll close this bug.

Pascal, regarding your two points:

1) there's a bug 740989 for the checkbox issue you mention
2) I created bug 854487 for the localized country names, but I'm not sure I understand the actual mechanics of it. Could you please update bug 854487 with your ideas?

Comment 13

[Matt Brandt [:mbrandt]]

Bumping to verified as [qa-]