Closed
Bug 850395
Opened 11 years ago
Closed 11 years ago
Allow per-device jobs
Categories
(Testing Graveyard :: Autophone, defect)
Testing Graveyard
Autophone
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mcote, Unassigned)
Details
Attachments
(1 file)
4.69 KB,
patch
|
bc
:
review+
|
Details | Diff | Splinter Review |
The triggerjobs command (and by extension the trigger_runs.py script) always starts a job on every device. Since sometimes devices die or go crazy during a run, it would be nice to have the ability to run jobs on particular devices to fill in gaps. I'll just extend the triggerjobs command to "triggerjobs <build url> [device] [device] ...". If the commands start to get more complicated we can move to a better format, but this is fine for now.
Assignee | ||
Comment 1•11 years ago
|
||
Pretty simple. Also fixed an incorrect/confusing variable name in trigger_jobs.py and simplified it a bit.
Attachment #724160 -
Flags: review?(bclary)
Comment 2•11 years ago
|
||
Comment on attachment 724160 [details] [diff] [review] Allow device-specific jobs Review of attachment 724160 [details] [diff] [review]: ----------------------------------------------------------------- r+ with that optional nit. I think that it would be nicer/cleaner to not have the build server started by autophone handle the request. That way we couldn't get out of sync with the repos and buildtypes parameters. But I don't think that is worth it right now. ::: autophone.py @@ +247,4 @@ > elif cmd == 'log': > logging.info(params) > elif cmd == 'triggerjobs': > + response = self.trigger_jobs(params) or response If trigger_jobs returned 'ok, we could just do: response = self.trigger_jobs(params) @@ +399,5 @@ > + args = data.split(' ') > + if not args: > + return 'invalid args' > + self.start_tests(args[0], args[1:]) > + return '' return 'ok'
Attachment #724160 -
Flags: review?(bclary) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Changed as suggested. https://github.com/mozilla/autophone/commit/cc8be502c662d5aad7d3e9374883dee9e94abebf
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•2 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•