850927 - DoorHanger layout files are redundant

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Sriram Ramasubramanian [:sriram]]

There are 2 layout files for doorhangerpopup (and site_identity_popup) differing only my the width attribute. A good approach would be specify it as a theme level attribute, and use it here.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

Finally, just one layout file.

Comment 2

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This is a better patch.

Comment 4

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/505fbab9b980

Comment 5

[Phil Ringnalda (:philor)]

Backed out the whole push in https://hg.mozilla.org/integration/mozilla-inbound/rev/5eb7efc431c8 for mochitest-1 and robocop-2 errors about "Error inflating class android.widget.Button" like https://tbpl.mozilla.org/php/getParsedLog.php?id=20799813&tree=Mozilla-Inbound and https://tbpl.mozilla.org/php/getParsedLog.php?id=20798777&tree=Mozilla-Inbound

Comment 6

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c6e7a7888876

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c6e7a7888876