851146 - [B2G][Camera] Lock Screen: Camera doesn't get LazyLoader when loaded from LockScreen

Status: VERIFIED DUPLICATE of bug 853420

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Allen Maxwell]

Attachment: LogCat of event

Description:
When user opens camera from the locked screen, with phone lock enabled, the phone has an OOM event

Repro Steps:
1) Updated to Unagi Build ID: 20130314070204
2) Set passcode on phone (settings/phone lock)
3) Lock the screen (press power button)
4) Press power button
5) Press camera icon

Expected:
Camera launches and allows user to take pictures.

Actual:
The camera app stops loading (OOM)

Repro frequency:
100%, 2/2

Environmental  Variables:
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/dc3add076016
Gaia: 1e1c8c0ff2bc7f252fbe95016f108e38ece691a9

Notes:
Works with passcode disabled camera launches normally
Q Analysts Test Team Priority Rating: Pri 1

Comment 1

[Mike Habicher [:mikeh] (high bugzilla latency)]

The logcat doesn't show anything.

How can you tell this is an OoM condition?  What exactly happens on the screen when you follow the STR?

I can't reproduce with the STR using mozilla-inbound; will try with b2g18.

Comment 2

[Allen Maxwell]

Attachment: Screenshot

Comment 3

[Allen Maxwell]

Appeared as a crash but no crash report was generated 
Screenshot attached

Does not occur on:
Unagi Build ID: 20130313070202
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/2a8c49f56bb6
Gaia: acd6546cdd03284b3b8c12432fb9955868fc4c2b

Still occurs on:
Unagi Build ID: 20130314114915
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/8e9dd87b4f3b
Gaia: 69dbcd84085f10bec0c0189b926ffb535b14dcfe

Comment 4

[Mike Habicher [:mikeh] (high bugzilla latency)]

I can reproduce this error and see this in my logcat:

E( 2775:0xad7) [JavaScript Error: "ReferenceError: LazyLoader is not defined" {file: "app://system.gaiamobile.org/camera/js/camera.js" line: 3}]

I'm running:
- gecko: b2g18:a827df06cffb
- gaia: 686932e12a459848be29eb407991383dfb45b8af

djf, I just noticed there's a whole second copy of the camera in $GAIA/apps/system/.  I don't see it in github, so I assume it's copied from $GAIA/apps/camera/ as part of the build/install process.

The copied index.html includes:
    <script defer src="shared/js/lazy_loader.js"></script>

...but I'm guessing that relative path is no good for accessing the LazyLoader?  (Does that mean we'll have to copy the LazyLoader into the system folder as well??)

Comment 5

[David Flanagan [:djf]]

Yes, it is just a straight copy of the camera app in the system app. The other shared files used by camera use absolute paths, so maybe changing adding a / prefix in apps/camera/index.html would fix it.

But there have also been a number of bugs on v1.0.1 because the patch that introduced LazyLoader did not get uplifted before the patches that use it.  So if you're seeing this on a v1.0.1 build it is probably because of that and will go away as soon as lazy_loader.js gets uplifted.

And if that is not it, then maybe it is an issue with the build system not being smart enough to copy the shared files for this copy of the camera app to where they need to go. You could probably fake it out, if necessary, by adding a commented out script to apps/system/index.html.

Comment 6

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: Github PR - make relative path to lazy_loader.js absolute

I've confirmed that with this change, the camera app (still) works and the lockscreen-with-passcode camera works (again).

Comment 7

[David Flanagan [:djf]]

Comment on attachment 725170 [details]
Github PR - make relative path to lazy_loader.js absolute

Trivial r+. Mike says he has tested and that it fixes the bug.

The travis build failed with an unrelated error in the Calendar app.

Merged into master: https://github.com/mozilla-b2g/gaia/commit/73256c6d67a87731430cb303a546c9ab06533b90

Comment 8

[Alex Keybl [:akeybl]]

leo+, may end up being tef+ if v1.0.1 is affected (adding qawanted).

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit 73256c6d67a87731430cb303a546c9ab06533b90 as:
v1-train: c70409129248807ec392fef7065d806d8ab6dacb

Comment 10

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Yes, this affects 1.0.1 as well:

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/4931ec89ebbe
Gaia   c33b1f8b60edc223ba86dd22f912effee990132a
BuildID 20130327070203
Version 18.0

Comment 11

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

noming for tef based on comment 8.

Comment 12

[David Flanagan [:djf]]

Its a trivial one-character patch. Should be easy to triage :-)

Comment 13

[Alex Keybl [:akeybl]]

(In reply to Naoki Hirata :nhirata from comment #11)
> noming for tef based on comment 8.

Not my call, but I agree we should block for tef+.

Comment 14

[Michael Vines [:m1] [:evilmachines]]

(passing the buck here, because I'm out of the tef+ biz now)

Comment 15

[Allen Maxwell]

This issue is still reproducable on 3/28 Commercial and Mozilla RIL:
Build ID: 20130328070204
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/dc653b5b2339
Gaia: 6dbf0b68622aa80d079fee2af660ddc47f7cd7df

Comment 16

[Mike Habicher [:mikeh] (high bugzilla latency)]

Looks like the patch is applied in master and v1-train, but not v1.0.1.

Comment 17

[Daniel Coloma:dcoloma]

It seems that patch at bug 853420 should be enough to solve this issue, right?

Comment 18

[Daniel Coloma:dcoloma]

Marking it as duplicated of bug 853420 to ease tracking.

Comment 19

[Mike Habicher [:mikeh] (high bugzilla latency)]

(In reply to Daniel Coloma:dcoloma from comment #17)
>
> It seems that patch at bug 853420 should be enough to solve this issue, right?

Looks like it will, yes.

Comment 20

[Natalya Kot [:nkot]]

confirming - the issue has been fixed, 

as per comment #7 in bug 853420 "User no longer has to put in the screen lock code in order to use camera"

tested on both, v1.0.1 and v1-train

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/45aa5ba0ed53
Gaia   cf2d4136f0ebc66039637fdbeb72ed184dfbc0f2
Build  20130429070204
Version 18.0
Inari

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/6c2493de1441
Gaia   c9046a7acef33328977840176ff5574720d2c74c
Build  20130426070204
Version 18.0
Leo