851306 - Fix MSVC C4244 build warnings (for type conversions) in Telemetry.cpp

Status: RESOLVED WORKSFORME

(Toolkit :: Telemetry, defect)

Description

[Daniel Holbert [:dholbert]]

MSVC has these build warnings for Telemetry.cpp:
{
e:/builds/moz2_slave/try-w32-d-00000000000000000000/build/toolkit/components/telemetry/Telemetry.cpp(547) : warning C4244: 'argument' : conversion from 'int64_t' to 'double', possible loss of data

e:/builds/moz2_slave/try-w32-d-00000000000000000000/build/toolkit/components/telemetry/Telemetry.cpp(815) : warning C4244: 'argument' : conversion from 'int64_t' to 'uint32_t', possible loss of data

e:/builds/moz2_slave/try-w32-d-00000000000000000000/build/toolkit/components/telemetry/Telemetry.cpp(2135) : warning C4244: 'initializing' : conversion from 'double' to 'uint32_t', possible loss of data

e:/builds/moz2_slave/try-w32-d-00000000000000000000/build/toolkit/components/telemetry/Telemetry.cpp(2393) : warning C4244: 'argument' : conversion from 'int64_t' to 'uint32_t', possible loss of data
}

Comment 1

[Daniel Holbert [:dholbert]]

Build log w/ these warnings treated as errors:
 https://tbpl.mozilla.org/php/getParsedLog.php?id=20652593&tree=Try

Comment 2

[Daniel Holbert [:dholbert]]

Note: bug 851183 just landed, marking this directory as FAIL_ON_WARNINGS for non-MSVC compilers.

When the warnings described in this bug here are fixed, we can remove the "_MSC_VER" check (exempting MSVC) there.

Comment 3

[Daniel Holbert [:dholbert]]

We've actually disabled warning C4244 now, in bug 857863, so while the underlying issue presumably remains, the "causes warnings" aspect is WORKSFORME.

Comment 4

[Daniel Holbert [:dholbert]]

(And the _MSC_VER check noted in comment 2 will be going away in bug 858224.)