851489 - Private Browsing is not enabled after selecting "Always use private browsing mode"

Status: VERIFIED FIXED

(Firefox :: Private Browsing, defect)

Description

[Mitza]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.22 (KHTML, like Gecko) Chrome/25.0.1364.152 Safari/537.22

Steps to reproduce:

1. Launch the browser.
2. Open the Options (Prefereces) dialog on the Privacy tab.
3. Select "Use custom settings for history" for "Firefox will:" and check the "Always use private browsing mode" checkbox.
4. Click OK on the Restart Firefox dialog that just appeared.




Actual results:

After restarting Firefox, Private Browsing mode was not enabled.


Expected results:

Restarting Firefox in Private Browsing mode.

Comment 1

[Ioana (away)]

This is a Firefox 20 beta 5 regression (it doesn't reproduce on older versions). The obvious culprit is the fix for bug 842290.

Comment 2

[Josh Matthews [:jdm]]

Hmm, can't reproduce on OS X. I'll find a Windows machine to fix this.

Comment 3

[Ioana (away)]

Reproducible on the latest beta, nightly, and aurora builds.

Comment 4

[Mihai Morar, (:MihaiMorar)]

I confirm this is happening on my Win 7 x64 too on 20b5.

Comment 5

[u279076]

Nominating this for tracking given this is a recent regression.

Comment 6

[Josh Matthews [:jdm]]

Attachment: Delay restarting the browser until the preferences dialog elements are completely updated.

Comment 7

[(no longer active)]

Comment on attachment 725590 [details] [diff] [review]
Delay restarting the browser until the preferences dialog elements are completely updated.

Review of attachment 725590 [details] [diff] [review]:
-----------------------------------------------------------------

Please just set the value of the pref to the thing we want.  Also, make this change to both privacy.js copies!

Comment 8

[Josh Matthews [:jdm]]

Attachment: Delay restarting the browser until the preferences dialog elements are completely updated.

This worked.

Comment 9

[Josh Matthews [:jdm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/09bbdb7b40dd

Comment 10

[Josh Matthews [:jdm]]

Comment on attachment 725600 [details] [diff] [review]
Delay restarting the browser until the preferences dialog elements are completely updated.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 842290
User impact if declined: User can't enter permanent private browsing mode through one of two ways.
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): No risk outside of the problem being addressed. 
String or UUID changes made by this patch: None.

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/09bbdb7b40dd

Comment 12

[u279076]

Mitza, can you please confirm this is fixed with tomorrow's Nightly?

Comment 13

[bhavana bajaj [:bajaj]]

Comment on attachment 725600 [details] [diff] [review]
Delay restarting the browser until the preferences dialog elements are completely updated.

Approving the low risk patch on aurora as this is a recent regression from our last beta which does not respect the user setting of enabling Private Browsing mode(always) based on STR in description.

Comment 14

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 725600 [details] [diff] [review]
Delay restarting the browser until the preferences dialog elements are completely updated.

Since this only addresses the problem let's get this on beta asap in order to have the fix in tomorrow's beta build and get verified there before our final beta next week.

Comment 15

[Josh Matthews [:jdm]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1927b02869d6

Comment 16

[Josh Matthews [:jdm]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ea90d48c3fba

Comment 17

[(no longer active)]

It's too late now, but you pushed this with the wrong commit message!

Comment 18

[Mitza]

The issue does not reproduce anymore.
Shouldn't there be a way to warn the user that he is in PB mode When you select "Always use private browsing" mode.
Ex. When you select "New Private Window", a new window is opened and the left corner is purple.

Comment 19

[Ioana (away)]

Still reproducing on the latest Aurora build:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20130318 Firefox/21.0 (20130318042013)

(verified as fixed on Nightly).

Comment 20

[(no longer active)]

(In reply to comment #18)
> The issue does not reproduce anymore.

Great!

> Shouldn't there be a way to warn the user that he is in PB mode When you select
> "Always use private browsing" mode.
> Ex. When you select "New Private Window", a new window is opened and the left
> corner is purple.

Please file a different bug about that.  Thanks!

Comment 21

[u279076]

Ioana, can you please retest Aurora and Beta with builds generated on or after March 19? This didn't land on those branches until yesterday.

Comment 22

[Ioana (away)]

Verified as fixed on the 03/20 Aurora and Firefox 20 beta 6.
Mozilla/5.0 (Windows NT 6.1; rv:21.0) Gecko/20130320 Firefox/21.0
Mozilla/5.0 (Windows NT 6.1; rv:20.0) Gecko/20100101 Firefox/20.0