851563 - Memory leak in UnixSocketConsumer

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Eric Chou [:ericchou] [:echou]]

Caller passes UnixSocketConnector instance into UnixSocketConsumer::ListenSocket() and UnixSocketConsumer::ConnectSocket(), in general cases, after an UnixSocketImpl instance is created, it will in charge of deleting the UnixSocketConnector instance by holding it with a nsAutoPtr. However, at the beginning of these two functions, it would check if mImpl already exists. If it does, then return - without deleting the UnixSocketConnector instance.

Comment 1

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: v1: fix memory leak in UnixSocketConsumer

Comment 2

[Eric Chou [:ericchou] [:echou]]

try: https://tbpl.mozilla.org/?tree=Try&rev=538b9e479642

Comment 3

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5c8569d8e01e

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5c8569d8e01e