851684 - [B2G][Contacts][Settings]: Cannot update the contact's label, the update button is grayed out.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[sarsenyev]

Description:
Update button is grayed out when you are trying to update the label.

Repro Steps:
1) Updated to Unagi Build ID: 20130315070220
2) Open Contacts app
3) Choose any existed contact and tap on "Edit button"( pen icon in the right corner)
4) Change the "Mobile" label to "Work" label
5) Tap "Done"

Expected:
Update button is enable and the label "Mobile" changed to the
"Work label.

Actual:
The update icon is grayed out and disable for update.

Repro frequency:
100% 

Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/78be5f74e410
Gaia: cd028015a499e4fc3a652d7aa6eb9f81a1ea8cd7

Notes:
Q Analysts Test Team Priority Rating: Pri 2

Comment 1

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

Comment 2

[Lukas Blakk [:lsblakk] use ?needinfo]

Is this a regression?  Blocking regardless since this is pretty important functionality.

Comment 3

[Cristian Rodriguez (:crdlc)]

It is not a regression, it has never implemented, thanks

Comment 4

[Cristian Rodriguez (:crdlc)]

https://github.com/mozilla-b2g/gaia/commit/aad79d95bee682d0c5eeb53775237f3bdcc6a768

Comment 5

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit aad79d95bee682d0c5eeb53775237f3bdcc6a768 as:
v1-train: fc78e5f68e63e951e5fe12dc3ae186983bc839c3

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Reopening as I can see this bug in v1.0.1

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Setting qawanted to verify that v1.0.1 is affected.

Thanks.

Comment 8

[sarsenyev]

Environmental  Variables:
Unagi Build ID: 20130405070202
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/f35275c90b13
Gaia: 73c24b0b8fa34da37e5cbdda188595c2bd9b4c25

The bug still reproduces on "Unagi" device V1.0.1 build.
Unable to update info after changing the label

Comment 9

[Daniel Coloma:dcoloma]

Marking as FIXED as it is already landed in master and requesting uplift via tef+

Comment 10

[John Ford [:jhford] CET/CEST Berlin Time]

v1.0.1: 68f929f7a074c3bdf5b9f1065250e816ba1dfe68

Comment 11

[amiller]

The issue is fixed on Unagi Build ID: 20130404070204
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/e43e65ec89d2
Gaia: daea430624ec02f8d36a12d581fc4a3278c27cb7

User is able to select Work phone number field as a valid option inside the Contact edit screen.

Verified Fixed