851847 - Optimize nsBlockFrame::StealFrame when removing a normal flow child

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, defect)

Description

[Mats Palmgren (inactive)]

nsBlockFrame::StealFrame currently does a linear search over all lines
(including overflow lines) to find the given child frame.

We can optimize this in two ways: first, we now have a hash table for
lines that have many (>200) frames - we should use it when available;
second, we should test upfront if the given child is an inline or block
and then skip lines accordingly.

Comment 1

[Mats Palmgren (inactive)]

Attachment: fix

https://tbpl.mozilla.org/?tree=Try&rev=346b3251d96e

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 725823 [details] [diff] [review]
fix

r=me

Comment 3

[Mats Palmgren (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/85397e0a6dba

Comment 4

[Mats Palmgren (inactive)]

Oops, the above changeset had some unrelated changes in it -- backed out.

Comment 5

[Mats Palmgren (inactive)]

Landed the right patch this time:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a5170d1c3bac

Comment 6

[Joe Drew (not getting mail)]

https://hg.mozilla.org/mozilla-central/rev/a5170d1c3bac