851986 - Avoid calling a virtual function when getting the source for an AudioNodeStream

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Description

[(no longer active)]

Attachment: Patch (v1)

This is a micro optimization, but I did see this virtual call come up in one of my profiles, and it's not like that we're getting any runtime checks out of it in non-debug builds anyways.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 725959 [details] [diff] [review]
Patch (v1)

Review of attachment 725959 [details] [diff] [review]:
-----------------------------------------------------------------

I would just do
 AudioNodeStream* a = static_cast<AudioNodeStream*>(s);
 NS_ASSERTION(a == s->AsAudioNodeStream());

Comment 2

[(no longer active)]

Yeah, that's better:

https://hg.mozilla.org/integration/mozilla-inbound/rev/60ab8fd2676b

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/60ab8fd2676b

Comment 4

[(no longer active)]

Mass moving Web Audio bugs to the Web Audio component.  Filter on duckityduck.