852019 - The devtools tabs are streched on Linux

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Paul Rouget [:paul]]

Attachment: screenshot

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Not good

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Patch

Comment 3

[Paul Rouget [:paul]]

Comment on attachment 726555 [details] [diff] [review]
Patch

Does that stretch well if the font size is increased? I don't thing vertical margins are need. -moz-box-align:center should be enough in theory.

I won't have time to review that. Handing the review to Mihai.

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

I will change the alignment

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Patch v2

Changed max-height and centred in OSX, Linux & Windows.

Comment 6

[Victor Porof [:vporof][:vp]]

Attachment: not centered

They don't seem to be centered on OS X...

Comment 7

[Paul Rouget [:paul]]

(In reply to Victor Porof [:vp] from comment #6)
> Created attachment 727186 [details]
> not centered
> 
> They don't seem to be centered on OS X...

horizontally centered *

Comment 8

[Victor Porof [:vporof][:vp]]

(In reply to Paul Rouget [:paul] from comment #7)

Oh, this bug was about vertical alignment? Would it be a good idea to have horizontal alignment as well? My untrained eyes tells me that it could look better, but I may be wrong.

Comment 9

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Victor: At first I misunderstood as well but it looked horribe when vertically aligned.

https://hg.mozilla.org/integration/fx-team/rev/7a852243f456

Comment 10

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

s/vertically aligned/horizontally centered/

Comment 11

[Paul Rouget [:paul]]

(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #9)
> […] but it looked horribe when vertically aligned.

How so?

Comment 12

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

I suspect that I am just not used to seeing tabs with the icon and text centered. Horizontally Centering has been moved out to bug 852975.

Comment 13

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/7a852243f456